From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup
Date: Sun, 21 May 2023 19:36:47 +0200
Message-ID: <20230521173647.GG1391451@pb2> (raw)
In-Reply-To: <CAPYw7P4T2YDHgrD2G8=BqSrzaHomZ2f5sgVLDPFRztC+kb+=Qg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 3327 bytes --]
On Sun, May 21, 2023 at 01:24:06PM +0200, Paul B Mahol wrote:
> libavcodec/gifdec.c | 11 -
> libavformat/gifdec.c | 245 +++++------------------
> tests/ref/fate/gif-color | 348 ++++++++++++++++-----------------
> tests/ref/fate/gif-deal | 314 +++++++++++++++++++++++++++--
> tests/ref/fate/gif-disposal-background | 12 -
> tests/ref/fate/gif-disposal-restore | 6
> tests/ref/fate/gifenc-bgr4_byte | 348 ++++++++++++++++-----------------
> tests/ref/fate/gifenc-bgr8 | 348 ++++++++++++++++-----------------
> tests/ref/fate/gifenc-gray | 348 ++++++++++++++++-----------------
> tests/ref/fate/gifenc-pal8 | 348 ++++++++++++++++-----------------
> tests/ref/fate/gifenc-rgb4_byte | 348 ++++++++++++++++-----------------
> tests/ref/fate/gifenc-rgb8 | 348 ++++++++++++++++-----------------
> 12 files changed, 1585 insertions(+), 1439 deletions(-)
> a8f54d72293f55ac76ae2e004e57809d7e9b90c6 0003-avformat-gifdec-switch-to-using-gif-parser.patch
> From 866801d43a9cf4c90e86afde1963b8b684e92998 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Sat, 20 May 2023 14:13:27 +0200
> Subject: [PATCH 3/3] avformat/gifdec: switch to using gif parser
>
> Update fate, more correct as timebase is not reduced.
>
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
> libavcodec/gifdec.c | 11 +-
> libavformat/gifdec.c | 245 +++++------------
> tests/ref/fate/gif-color | 348 ++++++++++++-------------
> tests/ref/fate/gif-deal | 314 ++++++++++++++++++++--
> tests/ref/fate/gif-disposal-background | 12 +-
> tests/ref/fate/gif-disposal-restore | 6 +-
> tests/ref/fate/gifenc-bgr4_byte | 348 ++++++++++++-------------
> tests/ref/fate/gifenc-bgr8 | 348 ++++++++++++-------------
> tests/ref/fate/gifenc-gray | 348 ++++++++++++-------------
> tests/ref/fate/gifenc-pal8 | 348 ++++++++++++-------------
> tests/ref/fate/gifenc-rgb4_byte | 348 ++++++++++++-------------
> tests/ref/fate/gifenc-rgb8 | 348 ++++++++++++-------------
> 12 files changed, 1585 insertions(+), 1439 deletions(-)
breaks:fate-fits-demux
...
+0, 242, 242, 1, 14320, 0xa34e7331
+0, 243, 243, 1, 14320, 0xa34e7331
+0, 244, 244, 1, 14320, 0xa34e7331
+0, 245, 245, 1, 14320, 0xa34e7331
+0, 246, 246, 1, 14320, 0xa34e7331
+0, 247, 247, 1, 14320, 0xa34e7331
+0, 248, 248, 1, 14320, 0xa34e7331
+0, 249, 249, 1, 14320, 0xa34e7331
Test fits-demux failed. Look at tests/data/fate/fits-demux.err for details.
tests/Makefile:307: recipe for target 'fate-fits-demux' failed
make: *** [fate-fits-demux] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-21 17:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 9:38 Paul B Mahol
2023-05-21 10:05 ` Anton Khirnov
2023-05-21 11:24 ` Paul B Mahol
2023-05-21 17:36 ` Michael Niedermayer [this message]
2023-05-21 17:59 ` Paul B Mahol
2023-05-21 19:25 ` Paul B Mahol
2023-05-21 19:37 ` James Almer
2023-05-21 20:02 ` Paul B Mahol
2023-05-21 20:06 ` James Almer
2023-05-21 21:42 ` Paul B Mahol
2023-05-22 15:49 ` Paul B Mahol
2023-05-22 16:04 ` James Almer
2023-05-22 16:07 ` James Almer
2023-05-22 16:10 ` Anton Khirnov
2023-05-22 16:19 ` Paul B Mahol
2023-05-22 20:01 ` James Almer
2023-05-23 21:51 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230521173647.GG1391451@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git