[FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

[FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

[James Almer]

Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so
it's not a good idea to have it as the default.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/matroskaenc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 41e13b273d..ae05f528e3 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -3431,8 +3431,7 @@ const FFOutputFormat ff_matroska_muxer = {
     .p.mime_type       = "video/x-matroska",
     .p.extensions      = "mkv",
     .priv_data_size    = sizeof(MatroskaMuxContext),
-    .p.audio_codec     = CONFIG_LIBVORBIS_ENCODER ?
-                         AV_CODEC_ID_VORBIS : AV_CODEC_ID_AC3,
+    .p.audio_codec     = AV_CODEC_ID_AC3,
     .p.video_codec     = CONFIG_LIBX264_ENCODER ?
                          AV_CODEC_ID_H264 : AV_CODEC_ID_MPEG4,
     .init              = mkv_init,
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]

On Sat, May 20, 2023 at 09:42:33AM -0300, James Almer wrote:
> Vorbis is not usually supported by Smart TVs, receivers and set top boxes, so
> it's not a good idea to have it as the default.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/matroskaenc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I do have a mixed feeling about this

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

[Kieran Kunhya]

FFac3 on TVs and devices doesn't write some of the dynamic range control
fields and is super quiet on a lot of TVs. I would make AAC the default.

Kieran
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: change default audio codec for Matroska output

[Leo Izen]

On 5/20/23 15:51, Kieran Kunhya wrote:
> FFac3 on TVs and devices doesn't write some of the dynamic range control
> fields and is super quiet on a lot of TVs. I would make AAC the default.
> 

+1 for AAC being the default, considering that it's going to be 
supported more than probably anything else except perhaps ac3 and mp3.

- Leo Izen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".