From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 181B54649A for ; Fri, 19 May 2023 14:43:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3696168C10E; Fri, 19 May 2023 17:43:42 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C7C568B157 for ; Fri, 19 May 2023 17:43:35 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7A5CA240010 for ; Fri, 19 May 2023 14:43:34 +0000 (UTC) Date: Fri, 19 May 2023 16:43:33 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230519144333.GB1391451@pb2> References: <20230517070351.4849-1-chenhao@loongson.cn> <20230517070351.4849-2-chenhao@loongson.cn> MIME-Version: 1.0 In-Reply-To: <20230517070351.4849-2-chenhao@loongson.cn> Subject: Re: [FFmpeg-devel] [PATCH v2 1/7] avcodec/la: add LSX optimization for h264 idct. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5909492027499945346==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5909492027499945346== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H2KpQ9C2DUtn/ko0" Content-Disposition: inline --H2KpQ9C2DUtn/ko0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2023 at 03:03:45PM +0800, Hao Chen wrote: > From: Shiyou Yin >=20 > loongson_asm.S is LoongArch asm optimization helper. > Add functions: > ff_h264_idct_add_8_lsx > ff_h264_idct8_add_8_lsx > ff_h264_idct_dc_add_8_lsx > ff_h264_idct8_dc_add_8_lsx > ff_h264_idct_add16_8_lsx > ff_h264_idct8_add4_8_lsx > ff_h264_idct_add8_8_lsx > ff_h264_idct_add8_422_8_lsx > ff_h264_idct_add16_intra_8_lsx > ff_h264_luma_dc_dequant_idct_8_lsx > Replaced function(LSX is sufficient for these functions): > ff_h264_idct_add_lasx > ff_h264_idct4x4_addblk_dc_lasx > ff_h264_idct_add16_lasx > ff_h264_idct8_add4_lasx > ff_h264_idct_add8_lasx > ff_h264_idct_add8_422_lasx > ff_h264_idct_add16_intra_lasx > ff_h264_deq_idct_luma_dc_lasx > Renamed functions: > ff_h264_idct8_addblk_lasx =3D=3D> ff_h264_idct8_add_8_lasx > ff_h264_idct8_dc_addblk_lasx =3D=3D> ff_h264_idct8_dc_add_8_lasx >=20 > ./configure --disable-lasx > ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an > before: 155fps > after: 161fps > --- > libavcodec/loongarch/Makefile | 3 +- > libavcodec/loongarch/h264_deblock_lasx.c | 2 +- > libavcodec/loongarch/h264dsp_init_loongarch.c | 39 +- > libavcodec/loongarch/h264dsp_lasx.c | 2 +- > .../{h264dsp_lasx.h =3D> h264dsp_loongarch.h} | 60 +- > libavcodec/loongarch/h264idct.S | 659 ++++++++++++ > libavcodec/loongarch/h264idct_lasx.c | 498 --------- > libavcodec/loongarch/h264idct_loongarch.c | 185 ++++ > libavcodec/loongarch/loongson_asm.S | 946 ++++++++++++++++++ > 9 files changed, 1851 insertions(+), 543 deletions(-) > rename libavcodec/loongarch/{h264dsp_lasx.h =3D> h264dsp_loongarch.h} (6= 8%) > create mode 100644 libavcodec/loongarch/h264idct.S > delete mode 100644 libavcodec/loongarch/h264idct_lasx.c > create mode 100644 libavcodec/loongarch/h264idct_loongarch.c > create mode 100644 libavcodec/loongarch/loongson_asm.S There are whitespace errors: These could prevent pushing as the git hooks check for various whitespace issues =2Egit/rebase-apply/patch:1432: tab in indent. } else if (nnz) { =2Egit/rebase-apply/patch:881: new blank line at EOF. + =2Egit/rebase-apply/patch:1576: new blank line at EOF. + =2Egit/rebase-apply/patch:2528: new blank line at EOF. + warning: 4 lines add whitespace errors. [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --H2KpQ9C2DUtn/ko0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZGeLEQAKCRBhHseHBAsP q28AAJ0Z8ucM34DqWDR7mAX3l226at6RWwCdHRXYC7qOd2q7Z21x91FclKgexfU= =svvY -----END PGP SIGNATURE----- --H2KpQ9C2DUtn/ko0-- --===============5909492027499945346== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5909492027499945346==--