From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAC9145EEA for ; Wed, 17 May 2023 20:06:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 579B568C11B; Wed, 17 May 2023 23:06:39 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7FEE568BF41 for ; Wed, 17 May 2023 23:06:33 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 577BC240004 for ; Wed, 17 May 2023 20:06:31 +0000 (UTC) Date: Wed, 17 May 2023 22:06:29 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230517200629.GY1391451@pb2> References: <20230517102029.541-1-anton@khirnov.net> <20230517102029.541-31-anton@khirnov.net> <20230517200409.GX1391451@pb2> MIME-Version: 1.0 In-Reply-To: <20230517200409.GX1391451@pb2> Subject: Re: [FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8048037775670780525==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8048037775670780525== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="odUccfZnqCGldi4C" Content-Disposition: inline --odUccfZnqCGldi4C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2023 at 10:04:09PM +0200, Michael Niedermayer wrote: > On Wed, May 17, 2023 at 12:20:24PM +0200, Anton Khirnov wrote: > > It currently emulates the long-removed > > avcodec_decode_audio4/avcodec_decode_video2 APIs, which obfuscates the > > actual decoding flow. Restructure the decoding calls so that they > > naturally follow the new avcodec_send_packet()/avcodec_receive_frame() > > design. > >=20 > > This is not only significantly easier to read, but also shorter. >=20 > with this: > ./ffmpeg -y -threads:a 1 -i tickets/1208/702121h264-TTA.mkvtest82.mkv -bi= texact -vn file1208.mp3 >=20 > Both before and afterwards the output is empty and we see >=20 > Finishing stream without any data written to it. > Output file is empty, nothing was encoded >=20 > after this patch while the output is not any better, now ffmpeg proclaims > success with its return code >=20 > just to be sure i try reading the output >=20 > [mp3 @ 0x5635bab17900] Format mp3 detected only with low score of 1, misd= etection possible! > [mp3 @ 0x5635bab17900] Failed to read frame size: Could not seek to 1026. > [in#0 @ 0x5635bab177c0] Error opening input: Invalid argument >=20 > I dont think that convertion was successfull fiel seems here: ffmpeg-bugs/trac/ticket1208/702121h264-TTA.mkvtest82.mkv [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB During times of universal deceit, telling the truth becomes a revolutionary act. -- George Orwell --odUccfZnqCGldi4C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZGUzxQAKCRBhHseHBAsP q/RoAJ9pK9tfmJzch4SlTysRHRuNkOeLVgCfWSvv4kMS5+Py8fEMVMSSQP3++vk= =uICe -----END PGP SIGNATURE----- --odUccfZnqCGldi4C-- --===============8048037775670780525== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8048037775670780525==--