From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6261845ECE for ; Wed, 17 May 2023 20:04:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 11C9D68C111; Wed, 17 May 2023 23:04:20 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6BAED68C0B9 for ; Wed, 17 May 2023 23:04:13 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2613EE0002 for ; Wed, 17 May 2023 20:04:11 +0000 (UTC) Date: Wed, 17 May 2023 22:04:09 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230517200409.GX1391451@pb2> References: <20230517102029.541-1-anton@khirnov.net> <20230517102029.541-31-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230517102029.541-31-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8746031017601129874==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8746031017601129874== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+mfs7XF4MJu0zTM1" Content-Disposition: inline --+mfs7XF4MJu0zTM1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2023 at 12:20:24PM +0200, Anton Khirnov wrote: > It currently emulates the long-removed > avcodec_decode_audio4/avcodec_decode_video2 APIs, which obfuscates the > actual decoding flow. Restructure the decoding calls so that they > naturally follow the new avcodec_send_packet()/avcodec_receive_frame() > design. >=20 > This is not only significantly easier to read, but also shorter. with this: =2E/ffmpeg -y -threads:a 1 -i tickets/1208/702121h264-TTA.mkvtest82.mkv -bi= texact -vn file1208.mp3 Both before and afterwards the output is empty and we see Finishing stream without any data written to it. Output file is empty, nothing was encoded after this patch while the output is not any better, now ffmpeg proclaims success with its return code just to be sure i try reading the output [mp3 @ 0x5635bab17900] Format mp3 detected only with low score of 1, misdet= ection possible! [mp3 @ 0x5635bab17900] Failed to read frame size: Could not seek to 1026. [in#0 @ 0x5635bab177c0] Error opening input: Invalid argument I dont think that convertion was successfull [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates --+mfs7XF4MJu0zTM1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZGUzNAAKCRBhHseHBAsP q/a2AJ4iP2PR0KlwcRB/c/BD0D8yvgXrbQCfZpaV+lIWtA83i16j4wuHi+mQqHQ= =blW4 -----END PGP SIGNATURE----- --+mfs7XF4MJu0zTM1-- --===============8746031017601129874== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8746031017601129874==--