From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop
Date: Wed, 17 May 2023 22:04:09 +0200
Message-ID: <20230517200409.GX1391451@pb2> (raw)
In-Reply-To: <20230517102029.541-31-anton@khirnov.net>
[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]
On Wed, May 17, 2023 at 12:20:24PM +0200, Anton Khirnov wrote:
> It currently emulates the long-removed
> avcodec_decode_audio4/avcodec_decode_video2 APIs, which obfuscates the
> actual decoding flow. Restructure the decoding calls so that they
> naturally follow the new avcodec_send_packet()/avcodec_receive_frame()
> design.
>
> This is not only significantly easier to read, but also shorter.
with this:
./ffmpeg -y -threads:a 1 -i tickets/1208/702121h264-TTA.mkvtest82.mkv -bitexact -vn file1208.mp3
Both before and afterwards the output is empty and we see
Finishing stream without any data written to it.
Output file is empty, nothing was encoded
after this patch while the output is not any better, now ffmpeg proclaims
success with its return code
just to be sure i try reading the output
[mp3 @ 0x5635bab17900] Format mp3 detected only with low score of 1, misdetection possible!
[mp3 @ 0x5635bab17900] Failed to read frame size: Could not seek to 1026.
[in#0 @ 0x5635bab177c0] Error opening input: Invalid argument
I dont think that convertion was successfull
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-17 20:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 10:19 [FFmpeg-devel] [PATCH 01/36] fftools/ffmpeg: shorten a variable name Anton Khirnov
2023-05-17 10:19 ` [FFmpeg-devel] [PATCH 02/36] fftools/ffmpeg: drop a useless local variable Anton Khirnov
2023-05-17 10:19 ` [FFmpeg-devel] [PATCH 03/36] fftools/ffmpeg: replace stream timebase with decoded frame one Anton Khirnov
2023-05-17 10:19 ` [FFmpeg-devel] [PATCH 04/36] fftools/ffmpeg_filter: convert input frame timestamps Anton Khirnov
2023-05-17 10:19 ` [FFmpeg-devel] [PATCH 05/36] fftools/ffmpeg_filter: make sure pkt_duration matches duration Anton Khirnov
2023-05-17 10:19 ` [FFmpeg-devel] [PATCH 06/36] fftools/ffmpeg: rework applying input -r Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 07/36] tests/fate/ffmpeg: move a misplaced line Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 08/36] tests/fate/ffmpeg: add a test for input -r option Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 09/36] fftools/ffmpeg_filter: split finding an unused stream into a function Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 10/36] fftools/ffmpeg: return error codes from ist_*_add() Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 11/36] fftools/ffmpeg_demux: disallow using disabled input streams Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 12/36] fftools/ffmpeg_filter: only use fallback parameters when necessary Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 13/36] fftools/ffmpeg_filter: try configuring graphs from input EOF Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 14/36] fftools/ffmpeg: move ifilter_has_all_input_formats() to ffmpeg_filter Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 15/36] fftools/ffmpeg_filter: make input filter configured parameters private Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 16/36] fftools/ffmpeg_filter: drop a redundant error message Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 17/36] fftools/ffmpeg_filter: move InputFilter.ist to private data Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 18/36] fftools/ffmpeg_filter: move InputFilter.type " Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 19/36] fftools/ffmpeg_filter: keep track of the real filter input type Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 20/36] fftools/ffmpeg_filter: embed displaymatrix into private context Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 21/36] fftools/cmdutils: constify the argument of get_rotation() Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 22/36] fftools/ffmpeg: drop an obsolete hack Anton Khirnov
2023-05-26 6:22 ` Wang, Fei W
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 23/36] fftools/ffmpeg: eliminate InputStream.got_output Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 24/36] fftools/ffmpeg: replace an unreachable return with av_assert0(0) Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 25/36] fftools/ffmpeg: deobfuscate check_decode_result() call Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 26/36] fftools/ffmpeg: rework handling -max_error_rate Anton Khirnov
2023-05-18 6:19 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 27/36] fftools/ffmpeg: move a block to a more appropriate place Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 28/36] fftools/ffmpeg: split decoding loop out of process_input_packet() Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 29/36] fftools/ffmpeg: move decoding code to ffmpeg_dec Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 30/36] fftools/ffmpeg_dec: deobfuscate subtitle decoding Anton Khirnov
2023-05-17 20:15 ` Michael Niedermayer
2023-05-18 14:34 ` Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop Anton Khirnov
2023-05-17 20:04 ` Michael Niedermayer [this message]
2023-05-17 20:06 ` Michael Niedermayer
2023-05-18 6:41 ` Anton Khirnov
2023-05-18 6:36 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 32/36] fftools/ffmpeg: reindent after previous commit Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 33/36] fftools/ffmpeg_dec: merge check_decode_result() into its callers Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 34/36] fftools/ffmpeg_dec: deduplicate code in decode_audio/video() Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 35/36] fftools/ffmpeg_dec: inline decode_audio() into dec_packet() Anton Khirnov
2023-05-17 10:20 ` [FFmpeg-devel] [PATCH 36/36] fftools/ffmpeg_dec: rename decode_video() to video_frame_process() Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517200409.GX1391451@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git