Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1768 bytes --]

On Mon, May 15, 2023 at 12:40:50AM +0200, Kacper Michajlow wrote:
> On Sun, 14 May 2023 at 23:39, Michael Niedermayer
> <michael@niedermayer.cc> wrote:
> >
> > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote:
> > > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which
> > > broke many streams in the wild
> > >
> > > Fixes #10353.
> >
> > This change violates a SHOULD in rfc8216 4.  Playlists
> >
> >    Each Playlist file MUST be identifiable either by the path component
> >    of its URI or by HTTP Content-Type.
> 
> either/or
> 
> >  In the first case, the path MUST
> >    end with either .m3u8 or .m3u.
> 
> First case, path component with valid extention.
> 
> >  In the second, the HTTP Content-Type
> >    MUST be "application/vnd.apple.mpegurl" or "audio/mpegurl".
> 
> Second (OR) case for URI with Content-Type.
> 
> So current FFmpeg HEAD violate RFC, as it should allow URI with Content-Type.

yes, code is buggy, i didnt see teh report before today night, 
and was doing too much non ffmpeg crap last 2-3 days so didnt see it before

everyone is upset, noone mailed me, noone posted a good fix, noone reverted

ill post something before going to sleep today probably but i likely
wont have the time to properly test it before bed
(testcases with ffmpeg / ffplay btw makes it easier to test than with
 links to random webpages)

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".