Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --]

On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote:
> This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which
> broke many streams in the wild
> 
> Fixes #10353.

This change violates a SHOULD in rfc8216 4.  Playlists

   Each Playlist file MUST be identifiable either by the path component
   of its URI or by HTTP Content-Type.  In the first case, the path MUST
   end with either .m3u8 or .m3u.  In the second, the HTTP Content-Type
   MUST be "application/vnd.apple.mpegurl" or "audio/mpegurl".  
   
   Clients SHOULD refuse to parse Playlists that are not so identified.
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The commit message should mention the RFC and why it is not following the
recommandition of not parsing such Playlists

Also ive taken a very brief look at #10353 and the example there shown
seems to fail because of the "?..." stuff in the url, it seemed to be
.m3u8 files, only the leaves seemes .ts

I do not object to revert this as a temporary fix of course

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".