From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6ED8D45E60 for ; Sun, 14 May 2023 09:14:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2549268BEE0; Sun, 14 May 2023 12:14:49 +0300 (EEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAD5668AB4A for ; Sun, 14 May 2023 12:14:42 +0300 (EEST) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3090d3e9c92so1055662f8f.2 for ; Sun, 14 May 2023 02:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684055680; x=1686647680; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=zkZxgOpWg0KwTbD+H0hXe3vAUiJ4JrQSmhijQn1AzIQ=; b=jbaReWFAiuaCfTGN/NhqTyxOskUjVY3wxUhww/qeB8BWXQKplTQoLoHNR58D0XgGYn 2E7dr5bpGCYcDBcByad9J1T1PesR1Bpyh/axn95mF7SjJpbVgJyHjPcqlxc7Ps0bRT8b ebzi0mTCFXRgne29EUF+2nRLn+Lb+UMl3zIMFC8wsBMSMWMmHf7cX5Tc0ScwbUWL5UrL fNQwWxxxIsZ+iFueonjb/vyyRkIolbAwpY3XlTapjUlL3yQf29NPHhxWeJzLWriuo30j +RMGDmUINdORrilAXfEsslPs4zjTqY0kg0QDqMaXxvtyTTIq3w3hyvWZ+mY+hpEiUOIr 74jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684055680; x=1686647680; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zkZxgOpWg0KwTbD+H0hXe3vAUiJ4JrQSmhijQn1AzIQ=; b=RPSTSH08gDGwQkSkP7IrunGFWtbSypyGwmeVG6xlefdXFSjXDPPE5g9JxOxeClTiM4 sy7ds1sMtu7yyrJKl4iVRPe0Tg48xlaw1tL6CM04Dab2KBfNYNh7Q3/MxQeKraVN6vfR bRAZtiAxVJP/4fjN1CSHGYgd5IA8g836vE5ekKdOuF7yThozu00UnJn1F7vWwEvuQcqg dZ+ER6JWowP90LTJPO+N/mW+n0x0+MW4SknMpWw78Mkt2IRyos1Cea7lHwmFTpyT+MH6 6kLScntPVrh+kMt4jDLMU+d5L53MK0KRmGELq2W/FRVUphaL41GKy+PPPHwKIQPupmDr usPg== X-Gm-Message-State: AC+VfDxJ7kazwQ0TOsrj4/EHJJJrtujpa/GRS8Ccr+qqKIhuKBdcE1Ko EznmNy5NaPlUO4bZ2ZRvDElAstS5ktY= X-Google-Smtp-Source: ACHHUZ7/YI8Mul6miLx68tVM+slZtHDsSVbkx4aqztqFYE/XbEdYGVs4MxVuvRUh20snlp0+/vWIfQ== X-Received: by 2002:adf:f1cd:0:b0:307:71c6:8a4c with SMTP id z13-20020adff1cd000000b0030771c68a4cmr22543436wro.52.1684055680365; Sun, 14 May 2023 02:14:40 -0700 (PDT) Received: from mariano ([91.254.67.164]) by smtp.gmail.com with ESMTPSA id p6-20020adfe606000000b002e5f6f8fc4fsm28874996wrm.100.2023.05.14.02.14.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 May 2023 02:14:39 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id F0EF4BFB73; Sun, 14 May 2023 11:14:38 +0200 (CEST) Date: Sun, 14 May 2023 11:14:38 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230514091438.GI4348@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230507224648.GE4348@mariano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] avfilter/setpts: add command support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Wednesday 2023-05-10 00:12:52 +0100, Oleg Afanasyev wrote: > On Sun, 7 May 2023 at 23:47, Stefano Sabatini wrote: [...] > > > > what happens in case setpts->expr is freed and this fails? > > > > probably it should keep a reference to expr and remove it only in case > > the new expression was successfully parsed > > Fixed! Didn't realize that encoding continues even if command fails, > so it was crashing with the previous expression still in place. > > > > > [...] > > > > Looks good to me otherwise. Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".