From: Leo Izen <leo.izen@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: Leo Izen <leo.izen@gmail.com> Subject: [FFmpeg-devel] [PATCH] avformat/hls: look for trailing GET headers with m3u8 extension check Date: Fri, 12 May 2023 16:26:22 -0400 Message-ID: <20230512202622.29531-1-leo.izen@gmail.com> (raw) After commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1 we refuse to use URLs of the form https://foo.bar/baz.m3u8?foo=bar because it fails the file extension check. This commit strips the ?foo=bar at the end before checking the file extension. Signed-off-by: Leo Izen <leo.izen@gmail.com> --- libavformat/hls.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 11e345b280..6a97cced17 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2534,7 +2534,16 @@ static int hls_probe(const AVProbeData *p) strstr(p->buf, "#EXT-X-TARGETDURATION:") || strstr(p->buf, "#EXT-X-MEDIA-SEQUENCE:")) { - if (!av_match_ext(p->filename, "m3u8,hls,m3u")) { + char *request_qmark = strchr(p->filename, '?'); + int match_ext; + + if (request_qmark) + *request_qmark = '\0'; + match_ext = av_match_ext(p->filename, "m3u8,hls,m3u"); + if (request_qmark) + *request_qmark = '?'; + + if (!match_ext) { av_log(NULL, AV_LOG_ERROR, "Not detecting m3u8/hls with non standard extension\n"); return 0; } -- 2.40.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-05-12 20:26 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-12 20:26 Leo Izen [this message] 2023-05-13 14:54 ` Michael Niedermayer 2023-05-13 17:06 ` Leo Izen 2023-05-14 20:43 ` Michael Niedermayer 2023-05-14 21:03 ` Leo Izen 2023-05-14 21:38 ` Michael Niedermayer 2023-05-16 12:41 ` Rémi Denis-Courmont 2023-05-14 9:31 ` Andreas Rheinhardt 2023-05-14 12:03 ` Leo Izen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230512202622.29531-1-leo.izen@gmail.com \ --to=leo.izen@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git