Re: [FFmpeg-devel] [PATCH] swresample: reuse DSP functions from avutil

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] swresample: reuse DSP functions from avutil
Date: Fri, 12 May 2023 16:09:11 +0200
Message-ID: <20230512140911.GD1391451@pb2> (raw)
In-Reply-To: <CAPYw7P4Set24dG+dZge_d97+hfTRaaEeyr41Md76Ht3bT=WY2Q@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1984 bytes --]

On Wed, May 10, 2023 at 04:25:06PM +0200, Paul B Mahol wrote:
> Attached.

>  rematrix.c            |   30 ++++++++++++++++++++++++++++--
>  swresample.c          |    5 +++++
>  swresample_internal.h |    2 ++
>  3 files changed, 35 insertions(+), 2 deletions(-)
> 2de854b7e4bacb3ea469a2fa6495053b679ae779  0001-swresample-reuse-DSP-functions-from-avutil.patch
> From 1f6aded57aab1fd8c6c7ba6fa5261d7979666f66 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Wed, 10 May 2023 15:41:01 +0200
> Subject: [PATCH] swresample: reuse DSP functions from avutil
> 
> Improves generic mixing dramatically.

Crashes
libswresample/tests/swresample
TEST: mono->quad, rate:16000->48000, fmt:dblp->dbl
==9257== 
==9257== Process terminating with default action of signal 11 (SIGSEGV)
==9257==  General Protection Fault
==9257==    at 0x15552E: ??? (libavutil/x86/float_dsp.asm:290)
==9257==    by 0x115B2A: swr_convert_internal (swresample.c:768)
==9257==    by 0x116676: swr_convert (swresample.c:889)
==9257==    by 0x11202E: main (swresample.c:355)
==9257== 
==9257== HEAP SUMMARY:
==9257==     in use at exit: 798,232 bytes in 59 blocks
==9257==   total heap usage: 352 allocs, 293 frees, 21,612,392 bytes allocated
==9257== 
==9257== LEAK SUMMARY:
==9257==    definitely lost: 2,992 bytes in 34 blocks
==9257==    indirectly lost: 0 bytes in 0 blocks
==9257==      possibly lost: 0 bytes in 0 blocks
==9257==    still reachable: 795,240 bytes in 25 blocks
==9257==         suppressed: 0 bytes in 0 blocks
==9257== Rerun with --leak-check=full to see details of leaked memory
==9257== 
==9257== For counts of detected and suppressed errors, rerun with: -v
==9257== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Segmentation fault (core dumped)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".