From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 740CA45DD1 for ; Thu, 11 May 2023 10:10:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81A5968BF8D; Thu, 11 May 2023 13:10:26 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2046C68A48F for ; Thu, 11 May 2023 13:10:20 +0300 (EEST) Received: from localhost (217-74-0-168.hsi.r-kom.net [217.74.0.168]) by haasn.dev (Postfix) with ESMTPSA id CF6F440E98; Thu, 11 May 2023 12:10:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail; t=1683799819; bh=aMwKkQ/RmvlpC6C0jyDSGNPBbnH+MLNSMQVcjxBGn7I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cnh9ogYiKrMMQkPwQ1dL9vNeUJ2tozZvVOZgd8YuL/y1OQds3fFn+s8jatXBzL5Iw ivQ+0lyNME226oKRlD9RiXA484X6mL1RD3Z/XA793M7QLBvxBBd58EgYwXWBoNSQzm Y1i3lb8yceAWegIaMcfXSeKDli+zBgexIHEFm3IA= Date: Thu, 11 May 2023 12:10:19 +0200 Message-ID: <20230511121019.GC12977@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: <168379883542.3843.47217330661696726@lain.khirnov.net> References: <20230511082850.5289-1-ffmpeg@haasn.xyz> <20230511083902.7262-1-ffmpeg@haasn.xyz> <168379883542.3843.47217330661696726@lain.khirnov.net> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2] lavfi/vf_libplacebo: add vulkan device import fallback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 11 May 2023 11:53:55 +0200 Anton Khirnov wrote: > Quoting Niklas Haas (2023-05-11 10:39:02) > > From: Niklas Haas > > > > Recent versions of libplacebo have required Vulkan versions incompatible > > with lavu Vulkan hwcontexts. > > Why did that happen? Did something change in lavu that broke things? No, upstream libplacebo dropped support, during a code refactor/simplification, for contexts without various features that used to be optional. That refactor is not yet in any tagged release, but it breaks current master+master building. Easiest alternative fix available right now would be to merge the vulkan lavu hwcontext changes that have been on ML for weeks (and gotten a LGTM from me). Alternatively, I could try and back-port enabling of whatever extensions and features are required onto the current Vulkan code. I understand not wanting random filters to open hardware devices under the hood, but I also think it's a bit silly to have to constantly synchronize requirements between Ffmpeg and libplacebo like this. If both have such tight requirements on device features and extensions, it makes more sense to me if each takes care of their own respective device creation. Or maybe FFmpeg vulkan could directly inspect `pl_vulkan_required_features` and enable whatever's listed in there, for forward compatibility. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".