Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] doc/filters/crop: drop unmatched quote in example
@ 2023-05-11 10:04 Andriy Utkin
  2023-05-11 10:22 ` Gyan Doshi
  0 siblings, 1 reply; 3+ messages in thread
From: Andriy Utkin @ 2023-05-11 10:04 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Andriy Utkin

Commit 55b81528a991 ("doc/filters: itemize crop examples") dropped the
quotation marks from these examples, but this one remained. Quotes are
actually needed to put the example into a command line or a program, but
removing it here makes the example consistent with the document.
---
 doc/filters.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/filters.texi b/doc/filters.texi
index 206fb23785..b6e13afdfd 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -10697,7 +10697,7 @@ crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(n/10):(in_h-out_h)/2 +((i
 @item
 Apply erratic camera effect depending on timestamp:
 @example
-crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 +((in_h-out_h)/2)*sin(t*13)"
+crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 +((in_h-out_h)/2)*sin(t*13)
 @end example
 
 @item
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] doc/filters/crop: drop unmatched quote in example
  2023-05-11 10:04 [FFmpeg-devel] [PATCH] doc/filters/crop: drop unmatched quote in example Andriy Utkin
@ 2023-05-11 10:22 ` Gyan Doshi
  2023-05-11 10:26   ` Gyan Doshi
  0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2023-05-11 10:22 UTC (permalink / raw)
  To: ffmpeg-devel



On 2023-05-11 03:34 pm, Andriy Utkin wrote:
> Commit 55b81528a991 ("doc/filters: itemize crop examples") dropped the
> quotation marks from these examples, but this one remained. Quotes are
> actually needed to put the example into a command line or a program, but
> removing it here makes the example consistent with the document.

Will apply.

Regards,
Gyan


> ---
>   doc/filters.texi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 206fb23785..b6e13afdfd 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -10697,7 +10697,7 @@ crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(n/10):(in_h-out_h)/2 +((i
>   @item
>   Apply erratic camera effect depending on timestamp:
>   @example
> -crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 +((in_h-out_h)/2)*sin(t*13)"
> +crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 +((in_h-out_h)/2)*sin(t*13)
>   @end example
>   
>   @item

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] doc/filters/crop: drop unmatched quote in example
  2023-05-11 10:22 ` Gyan Doshi
@ 2023-05-11 10:26   ` Gyan Doshi
  0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2023-05-11 10:26 UTC (permalink / raw)
  To: ffmpeg-devel

Applied as ceb050427c4c6758e6e0ffb2b82e5a76917a1d63

Thanks,
Gyan

On 2023-05-11 03:52 pm, Gyan Doshi wrote:
>
>
> On 2023-05-11 03:34 pm, Andriy Utkin wrote:
>> Commit 55b81528a991 ("doc/filters: itemize crop examples") dropped the
>> quotation marks from these examples, but this one remained. Quotes are
>> actually needed to put the example into a command line or a program, but
>> removing it here makes the example consistent with the document.
>
> Will apply.
>
> Regards,
> Gyan
>
>
>> ---
>>   doc/filters.texi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/doc/filters.texi b/doc/filters.texi
>> index 206fb23785..b6e13afdfd 100644
>> --- a/doc/filters.texi
>> +++ b/doc/filters.texi
>> @@ -10697,7 +10697,7 @@ 
>> crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(n/10):(in_h-out_h)/2 
>> +((i
>>   @item
>>   Apply erratic camera effect depending on timestamp:
>>   @example
>> -crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 
>> +((in_h-out_h)/2)*sin(t*13)"
>> +crop=in_w/2:in_h/2:(in_w-out_w)/2+((in_w-out_w)/2)*sin(t*10):(in_h-out_h)/2 
>> +((in_h-out_h)/2)*sin(t*13)
>>   @end example
>>     @item
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-11 10:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-11 10:04 [FFmpeg-devel] [PATCH] doc/filters/crop: drop unmatched quote in example Andriy Utkin
2023-05-11 10:22 ` Gyan Doshi
2023-05-11 10:26   ` Gyan Doshi

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git