From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D1F1A46170 for ; Mon, 8 May 2023 14:12:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 61D5B68C173; Mon, 8 May 2023 17:12:18 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08ADF68BF05 for ; Mon, 8 May 2023 17:12:11 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 4BBB32000C for ; Mon, 8 May 2023 14:12:10 +0000 (UTC) Date: Mon, 8 May 2023 16:12:08 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230508141208.GR1391451@pb2> References: <20230507133255.20881-1-anton@khirnov.net> <20230507133255.20881-4-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230507133255.20881-4-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 04/13] lavf: use AV_CODEC_PROP_FIELDS where appropriate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2804751155212861393==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2804751155212861393== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XMM+kVNHGkMezEqK" Content-Disposition: inline --XMM+kVNHGkMezEqK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 07, 2023 at 03:32:46PM +0200, Anton Khirnov wrote: > H.264 and mpeg12 parsers need to be adjusted at the same time to stop > using the value of AVCodecContext.ticks_per_frame, because it is not set > correctly unless the codec has been opened. Previously this would result > in both the parser and lavf seeing the same incorrect value, which would > cancel out. > Updating lavf and not the parsers would result in correct value in lavf, > but the wrong one in parsers, which would break some tests. > --- > libavcodec/h264_parser.c | 4 ++-- > libavcodec/mpegvideo_parser.c | 2 +- > libavformat/avformat.c | 9 ++++++--- > libavformat/demux.c | 29 +++++++++++++++++++---------- > libavformat/internal.h | 3 +++ > 5 files changed, 31 insertions(+), 16 deletions(-) breaks: ./ffmpeg -i ~/tickets/104/cartonfold.avi -bitexact -f framecrc - fps and timestamps look strange=20 =20 =20 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. --XMM+kVNHGkMezEqK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZFkDMwAKCRBhHseHBAsP qyZIAKCS6oQyglY7Y0mvOgPqoJj2fy1PFwCeMCPisJ2dUqeqTmC6D1p+XtnOaAI= =0rGC -----END PGP SIGNATURE----- --XMM+kVNHGkMezEqK-- --===============2804751155212861393== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2804751155212861393==--