From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E364544AA2 for ; Sun, 7 May 2023 21:21:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BBF7F680835; Mon, 8 May 2023 00:21:00 +0300 (EEST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 00EC368B723 for ; Mon, 8 May 2023 00:20:53 +0300 (EEST) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3063b5f32aaso2398804f8f.2 for ; Sun, 07 May 2023 14:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683494452; x=1686086452; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=DqJMbBJ1skLwbNKrbU85jQ//9fqxP+jVix1qSgm+B20=; b=XDtdj5q/NnFUrrGKpydrs/tsga2XDAPfKLWiJwOkXAGjd6+yOA0n8ph7z/MBIXDhm+ yZ1munuHfOjghqwH6us1/HWbhzeEmkR+qX+Gwtc8UDGPmRg8tM1A8ql1pDQI43DzDPve YDmD+JAyshC2N64mADYagbWja8y9YjF64Jj5n11Ds+zsb5BjwvC3QLqU36XV5BeJ6Wfu G/uicOF1BjZmyvp7MCT2vc2D2CTPgFPNQycTi526FhC8Lc3ch3hSJ3gG0DS8ZrHHa0eF Avw2gu/4+hHgdOUZGgmzyvz5WSnhtTlbWRHpGo0XRgmuOJHM4G+71rGWXU+6lipDFFBR /NYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683494452; x=1686086452; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DqJMbBJ1skLwbNKrbU85jQ//9fqxP+jVix1qSgm+B20=; b=k7UGqFtTugiCn/+CAVJjbmL+oFcDv23ZTFPl0eEagpe0B02Af9JIeYgWdNQBETlCe8 2uaKn0jTvhVsA8el6hYMnnc23wsLgwLnW6KEGXsHbTeE/HeIWdlI4pzDbWfTBDX7VBMw Mscu87JTgtZJs16+iYWIcBxFIBIQTStrmVC5GSO11ajNImxAAysCH620Z9VamQ9ZNOe6 hBrv6oID97A3lCWfqMujGUyhSUyqJyB43s6SfQ94hSxf9huUnNZx9hdjs1XhhYqkF6+h ZJu9Nb6zDgUfxGrhRkGceCG1pQvWjnv5JYd/s5qN2RpkG2bWcn3zqlKTZ1pGSh7ncGSD ejvw== X-Gm-Message-State: AC+VfDz3V2P8zACNSd10XT+UOZp+juNq0TI2uMPkb4XcnMYaWVrlKeDk Gd7O6eg8hs73lL10U/BiGTiLs5Yfv+lMZw== X-Google-Smtp-Source: ACHHUZ5UUc1qsEnaXai1lLwb/mXC3uma0Muc9FI3Z7MfNwK/bK73hPyTCdcAgbaGingEk0oS9AkKWA== X-Received: by 2002:adf:ee84:0:b0:306:3261:809 with SMTP id b4-20020adfee84000000b0030632610809mr5849412wro.50.1683494452610; Sun, 07 May 2023 14:20:52 -0700 (PDT) Received: from mariano ([91.254.67.164]) by smtp.gmail.com with ESMTPSA id n18-20020adfe792000000b002f7780eee10sm9272123wrm.59.2023.05.07.14.20.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 14:20:51 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 521AFBFB73; Sun, 7 May 2023 23:20:50 +0200 (CEST) Date: Sun, 7 May 2023 23:20:50 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230507212050.GA4348@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230505231856.29607-1-jamrial@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230505231856.29607-1-jamrial@gmail.com> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: print exported stream AVOptions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Friday 2023-05-05 20:18:56 -0300, James Almer wrote: > Similar to the decoder AVOptions above. Please briefly specify the use case in the log. > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 12 ++++++++++++ > tests/ref/fate/flv-demux | 4 ++-- > tests/ref/fate/ts-demux | 6 +++--- > tests/ref/fate/ts-opus-demux | 2 +- > tests/ref/fate/ts-small-demux | 2 +- > 5 files changed, 19 insertions(+), 7 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 43bf10db54..9599b3b1b2 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -3127,6 +3127,18 @@ static int show_stream(WriterContext *w, AVFormatContext *fmt_ctx, int stream_id > } > } > > + if (fmt_ctx->iformat->priv_class && show_private_data) { > + const AVOption *opt = NULL; > + while (opt = av_opt_next(fmt_ctx->priv_data, opt)) { > + uint8_t *str; > + if (!(opt->flags & AV_OPT_FLAG_EXPORT)) continue; > + if (av_opt_get(fmt_ctx->priv_data, opt->name, 0, &str) >= 0) { > + print_str(opt->name, str); > + av_free(str); > + } > + } > + } maybe factorize with the other similar code? [...] LGTM otherwise. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".