* [FFmpeg-devel] [PATCH] avdevice/lavfi: fix crash on unconnected outpads
@ 2023-05-07 10:34 metamuffin
0 siblings, 0 replies; 3+ messages in thread
From: metamuffin @ 2023-05-07 10:34 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: metamuffin
Nameless outpads would cause an invocation to sscanf with NULL.
Example: ffmpeg -f lavfi -i 'nullsrc;nullsrc' -
Changed to throwing an error instead.
---
libavdevice/lavfi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
index 9c1fcf334b..21f33ade0e 100644
--- a/libavdevice/lavfi.c
+++ b/libavdevice/lavfi.c
@@ -174,6 +174,11 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
* create a mapping between them and the streams */
for (i = 0, inout = output_links; inout; i++, inout = inout->next) {
int stream_idx = 0, suffix = 0, use_subcc = 0;
+ if (!inout->name) {
+ av_log(avctx, AV_LOG_ERROR,
+ "Filtergraph has nameless outpads\n");
+ FAIL(AVERROR(EINVAL));
+ }
sscanf(inout->name, "out%n%d%n", &suffix, &stream_idx, &suffix);
if (!suffix) {
av_log(avctx, AV_LOG_ERROR,
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avdevice/lavfi: fix crash on unconnected outpads
2023-06-01 10:13 metamuffin
@ 2023-06-01 21:40 ` Paul B Mahol
0 siblings, 0 replies; 3+ messages in thread
From: Paul B Mahol @ 2023-06-01 21:40 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: metamuffin
On Thu, Jun 1, 2023 at 12:14 PM metamuffin <metamuffin@disroot.org> wrote:
> Nameless outpads would cause an invocation to sscanf with NULL.
> Example: ffmpeg -f lavfi -i 'nullsrc;nullsrc' -
> Changed to throwing an error instead.
>
See:
https://git.videolan.org/?p=ffmpeg.git;a=commit;h=5ce76506de1a7fbaf91af47a925d5ecfe13ae59c
Perhaps needs backporting to first introduction.
> ---
> libavdevice/lavfi.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
> index 9c1fcf334b..21f33ade0e 100644
> --- a/libavdevice/lavfi.c
> +++ b/libavdevice/lavfi.c
> @@ -174,6 +174,11 @@ av_cold static int lavfi_read_header(AVFormatContext
> *avctx)
> * create a mapping between them and the streams */
> for (i = 0, inout = output_links; inout; i++, inout = inout->next) {
> int stream_idx = 0, suffix = 0, use_subcc = 0;
> + if (!inout->name) {
> + av_log(avctx, AV_LOG_ERROR,
> + "Filtergraph has nameless outpads\n");
> + FAIL(AVERROR(EINVAL));
> + }
> sscanf(inout->name, "out%n%d%n", &suffix, &stream_idx, &suffix);
> if (!suffix) {
> av_log(avctx, AV_LOG_ERROR,
> --
> 2.40.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] [PATCH] avdevice/lavfi: fix crash on unconnected outpads
@ 2023-06-01 10:13 metamuffin
2023-06-01 21:40 ` Paul B Mahol
0 siblings, 1 reply; 3+ messages in thread
From: metamuffin @ 2023-06-01 10:13 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: metamuffin
Nameless outpads would cause an invocation to sscanf with NULL.
Example: ffmpeg -f lavfi -i 'nullsrc;nullsrc' -
Changed to throwing an error instead.
---
libavdevice/lavfi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
index 9c1fcf334b..21f33ade0e 100644
--- a/libavdevice/lavfi.c
+++ b/libavdevice/lavfi.c
@@ -174,6 +174,11 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
* create a mapping between them and the streams */
for (i = 0, inout = output_links; inout; i++, inout = inout->next) {
int stream_idx = 0, suffix = 0, use_subcc = 0;
+ if (!inout->name) {
+ av_log(avctx, AV_LOG_ERROR,
+ "Filtergraph has nameless outpads\n");
+ FAIL(AVERROR(EINVAL));
+ }
sscanf(inout->name, "out%n%d%n", &suffix, &stream_idx, &suffix);
if (!suffix) {
av_log(avctx, AV_LOG_ERROR,
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-01 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-07 10:34 [FFmpeg-devel] [PATCH] avdevice/lavfi: fix crash on unconnected outpads metamuffin
2023-06-01 10:13 metamuffin
2023-06-01 21:40 ` Paul B Mahol
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git