From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8656540BF7 for ; Fri, 5 May 2023 14:10:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E69868BE0B; Fri, 5 May 2023 17:10:35 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34E5E6801F5 for ; Fri, 5 May 2023 17:10:28 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 6F6142000E for ; Fri, 5 May 2023 14:10:27 +0000 (UTC) Date: Fri, 5 May 2023 16:10:26 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230505141026.GI1391451@pb2> References: <1683237740-32743-1-git-send-email-dheitmueller@ltnglobal.com> <1683237740-32743-3-git-send-email-dheitmueller@ltnglobal.com> MIME-Version: 1.0 In-Reply-To: <1683237740-32743-3-git-send-email-dheitmueller@ltnglobal.com> Subject: Re: [FFmpeg-devel] [PATCH v5 2/6] vf_fps: properly preserve CEA-708 captions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6226938124162028891==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6226938124162028891== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sdJFN6SSISdF2ksn" Content-Disposition: inline --sdJFN6SSISdF2ksn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 04, 2023 at 06:02:16PM -0400, Devin Heitmueller wrote: > The existing implementation made an attempt to remove duplicate > captions if increasing the framerate, but made no attempt to > handle reducing the framerate, nor did it rewrite the caption > payloads to have the appropriate cc_count (e.g. the cc_count needs > to change from 20 to 10 when going from 1080i59 to 720p59 and > vice-versa). >=20 > Make use of the new ccfifo mechanism to ensure that caption data > is properly preserved. >=20 > Signed-off-by: Devin Heitmueller > --- > libavfilter/vf_fps.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) breaks fate make -j32 fate-filter-fps-down-eof-pass =2E.. =3D=3D28512=3D=3D Invalid read of size 8 =3D=3D28512=3D=3D at 0x11754A0: av_fifo_freep2 (in /home/michael/ffmpeg-= git/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x5A40F3: ff_ccfifo_freep (in /home/michael/ffmpeg-= git/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x2570D1: uninit (in /home/michael/ffmpeg-git/ffmpe= g/ffmpeg_g) =3D=3D28512=3D=3D by 0x34C1E2: avfilter_free (in /home/michael/ffmpeg-gi= t/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x34DCC3: avfilter_graph_free (in /home/michael/ffm= peg-git/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x2FCD32: init_complex_filtergraph (in /home/michae= l/ffmpeg-git/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x30F5F5: ffmpeg_parse_options (in /home/michael/ff= mpeg-git/ffmpeg/ffmpeg_g) =3D=3D28512=3D=3D by 0x2F1254: main (in /home/michael/ffmpeg-git/ffmpeg/= ffmpeg_g) =3D=3D28512=3D=3D Address 0x0 is not stack'd, malloc'd or (recently) free'd [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting. --sdJFN6SSISdF2ksn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZFUOTgAKCRBhHseHBAsP q9d4AKCA9stRPDvI3zEZS6B7wHAv+BvyowCdHsxqdj9pYXfTj1F7ylswzZ5RGUs= =bpqc -----END PGP SIGNATURE----- --sdJFN6SSISdF2ksn-- --===============6226938124162028891== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6226938124162028891==--