From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31ABD45D04 for ; Thu, 4 May 2023 12:13:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81DC668C0C2; Thu, 4 May 2023 15:13:06 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BFC168BFE6 for ; Thu, 4 May 2023 15:13:00 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 844691C0005 for ; Thu, 4 May 2023 12:12:59 +0000 (UTC) Date: Thu, 4 May 2023 14:12:58 +0200 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20230504121258.GD3718108@pb2> References: <20230502093136.B998A4107DA@natalya.videolan.org> MIME-Version: 1.0 In-Reply-To: <20230502093136.B998A4107DA@natalya.videolan.org> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3407559793729941777==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3407559793729941777== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wchHw8dVAp53YPj8" Content-Disposition: inline --wchHw8dVAp53YPj8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 02, 2023 at 09:31:35AM +0000, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Wed Apr 26 = 10:51:38 2023 +0200| [129c7bf53fbe2be4f5483ecf6fc036ff9caf05cf] | committer= : Anton Khirnov >=20 > fftools/ffmpeg: always use the same path for setting InputStream.[next_]d= ts >=20 > Currently those are set in different ways depending on whether the > stream is decoded or not, using some values from the decoder if it is. > This is wrong, because there may be arbitrary amount of delay between > input packets and output frames (depending e.g. on the thread count when > frame threading is used). >=20 > Always use the path that was previously used only for streamcopy. This > should not cause any issues, because these values are now used only for > streamcopy and discontinuity handling. >=20 > This change will allow to decouple discontinuity processing from > decoding and move it to ffmpeg_demux. It also makes the code simpler. >=20 > Changes output in fate-cover-art-aiff-id3v2-remux and > fate-cover-art-mp3-id3v2-remux, where attached pictures are now written > in the correct order. This happens because InputStream.dts is no longer > reset to AV_NOPTS_VALUE after decoding, so streamcopy actually sees > valid dts values. >=20 > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D129c7bf53= fbe2be4f5483ecf6fc036ff9caf05cf > --- >=20 > fftools/ffmpeg.c | 34 +++++--------------------= ------ > tests/ref/fate/cover-art-aiff-id3v2-remux | 34 +++++++++++++++----------= ------ > tests/ref/fate/cover-art-mp3-id3v2-remux | 22 ++++++++++---------- > 3 files changed, 33 insertions(+), 57 deletions(-) Causes assertion failures Assertion pkt->duration >=3D 0 failed at fftools/ffmpeg.c:1502 Aborted (core dumped) ill send you the file privately [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. --wchHw8dVAp53YPj8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZFOhRgAKCRBhHseHBAsP qw/uAJwMhoNNWvh6vUxqhJb4v8olc34bbwCeN58/BGvRTZRNj2AyhfIEdFEeEIA= =p1vv -----END PGP SIGNATURE----- --wchHw8dVAp53YPj8-- --===============3407559793729941777== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3407559793729941777==--