From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/pdvdec: Check previous frame before using it
Date: Tue, 2 May 2023 17:38:20 +0200
Message-ID: <20230502153820.32234-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20230502153820.32234-1-michael@niedermayer.cc>
Fixes: load of null pointer of type 'uint8_t' (aka 'unsigned char')
Fixes: 58256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PDV_fuzzer-4776436325285888
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/pdvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/pdvdec.c b/libavcodec/pdvdec.c
index b1fc19b1c9..605af78050 100644
--- a/libavcodec/pdvdec.c
+++ b/libavcodec/pdvdec.c
@@ -93,7 +93,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
return AVERROR_INVALIDDATA;
}
- if (!(avpkt->flags & AV_PKT_FLAG_KEY)) {
+ if (prev && !(avpkt->flags & AV_PKT_FLAG_KEY)) {
for (int j = 0; j < (avctx->width + 7) >> 3; j++)
dst[j] ^= prev[j];
prev += prev_frame->linesize[0];
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-02 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 15:38 [FFmpeg-devel] [PATCH 1/3] avcodec/rka: avoid undefined multiply in cmode==0 Michael Niedermayer
2023-05-02 15:38 ` [FFmpeg-devel] [PATCH 2/3] avformat/oggparsetheora: clip duration within 64bit Michael Niedermayer
2023-05-02 15:38 ` Michael Niedermayer [this message]
2023-05-02 15:39 ` [FFmpeg-devel] [PATCH 3/3] avcodec/pdvdec: Check previous frame before using it Paul B Mahol
2023-05-05 21:56 ` Michael Niedermayer
2023-06-03 18:59 ` [FFmpeg-devel] [PATCH 1/3] avcodec/rka: avoid undefined multiply in cmode==0 Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502153820.32234-3-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git