From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 1307645032
	for <ffmpegdev@gitmailbox.com>; Fri, 28 Apr 2023 13:28:36 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7679268BFBC;
	Fri, 28 Apr 2023 16:28:33 +0300 (EEST)
Received: from haasn.dev (haasn.dev [78.46.187.166])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A4BB68BF70
 for <ffmpeg-devel@ffmpeg.org>; Fri, 28 Apr 2023 16:28:26 +0300 (EEST)
Received: from haasn.dev (unknown [10.30.0.2])
 by haasn.dev (Postfix) with ESMTP id 60A23407CB
 for <ffmpeg-devel@ffmpeg.org>; Fri, 28 Apr 2023 15:28:26 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=haasn.xyz; s=mail;
 t=1682688506; bh=t7XgypUUmOCd4wY7G/zJPa1o367Y+eUDS38LPbQ9t1U=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=fLx4Tdtk9LWy6nFhRiHw3biNSkOHsJtHP4yIh/pX5AAOYgZRxwN5ZHOwh2BZWz7Jr
 i4vrp8R41RBu9ecqbLdGuM24EgpPPtwydzv2ZiBsPTkqzcuhBHwX0TBuFYWRzFBOAZ
 oAbgy9knjtOyMEZve5GQEMMGRBiOxf0UdcZ7cn8U=
Date: Fri, 28 Apr 2023 15:28:26 +0200
Message-ID: <20230428152826.GB90677@haasn.xyz>
From: Niklas Haas <ffmpeg@haasn.xyz>
To: Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <NTnyn9K--3-9@lynne.ee>
References: <NTnyn9K--3-9@lynne.ee>
MIME-Version: 1.0
Content-Disposition: inline
Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext
 rewrite and filtering
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20230428152826.GB90677@haasn.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 24 Apr 2023 17:56:38 +0200 Lynne <dev@lynne.ee> wrote:
> This is part two of the vulkan patchset, which contains all the
> hwcontext and vulkan.c rewrites, and filtering changes.
> 
> 55 patches attached.

The new Vulkan code looks like a clear improvement over the status quo
to me. I tested it locally and everything works as expected. The new
synchronization code LGTM overall.

As noted over IRC I think it specifies unnecessarily strict
execution/memory dependencies, though I think it's better to merge a
working state first than to play the microoptimization game at this
stage. (It's also worth noting that this code is still significantly
slower than vf_libplacebo's native hwupload/hwdownload primitives, for
as-of-yet-to-be-determined reasons)

That said, I'm still in favor of this subset of your patchset being
merged soon, since it fixes major issues that prevent the current Vulkan
code on master from working properly with mpv/libplacebo.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".