From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A06B745368 for ; Wed, 26 Apr 2023 11:54:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D52868BE9E; Wed, 26 Apr 2023 14:54:18 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 71BC268B73B for ; Wed, 26 Apr 2023 14:54:12 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 9B4FA60006 for ; Wed, 26 Apr 2023 11:54:11 +0000 (UTC) Date: Wed, 26 Apr 2023 13:54:10 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230426115410.GD275832@pb2> References: <20230424155553.24560-1-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230424155553.24560-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavf/dv: do not set video timebase more than once X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7753865023903201291==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7753865023903201291== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/EQiL+SffV/fXkvV" Content-Disposition: inline --/EQiL+SffV/fXkvV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 24, 2023 at 05:55:51PM +0200, Anton Khirnov wrote: > Current code will call avpriv_set_pts_info() for each video frame, > possibly setting a different timebase if the stream framerate changes. > This violates API conventions, as the timebase is supposed to stay > constant after stream creation. >=20 > Change the demuxer to set a single timebase that is fine enough to > handle all supported DV framerates. >=20 > The seek tests change slightly because the new timebase is more > granular. > --- > libavcodec/dv.h | 3 +++ > libavformat/dv.c | 25 ++++++++++++++++++++----- > tests/ref/seek/lavf-dv | 16 ++++++++-------- > tests/ref/seek/vsynth_lena-dv | 24 ++++++++++++------------ > tests/ref/seek/vsynth_lena-dv-411 | 24 ++++++++++++------------ > tests/ref/seek/vsynth_lena-dv-50 | 24 ++++++++++++------------ > 6 files changed, 67 insertions(+), 49 deletions(-) This breaks: =2E/ffmpeg -ss 4:56 -i ~/tickets/4086/Oca-Agu\ 1995.avi -codec copy -t 1 -b= itexact 4086-30frames.dv (the file is empty after the patch) The file seems no longer available on the original link and a little big ill put it in your home directory on the server probably in 30+min or so. once you are done with it please delete it off the server so it doesnt eat diskspace thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It reveals fear. -- Julian Assange --/EQiL+SffV/fXkvV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZEkQ3QAKCRBhHseHBAsP qwiyAKCHw/ZbyRomdpDNwAV+fMqFoSUMdgCeK9A51w7l7ypUxYiyS41H8Av8ciQ= =hsEb -----END PGP SIGNATURE----- --/EQiL+SffV/fXkvV-- --===============7753865023903201291== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7753865023903201291==--