Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Tong Wu <tong1.wu-at-intel.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Tong Wu <tong1.wu@intel.com>
Subject: [FFmpeg-devel] [PATCH v5 2/5] avfilter/vf_hwmap: get the AVHWDeviceType from outlink format
Date: Tue, 25 Apr 2023 15:26:17 +0800
Message-ID: <20230425072620.512-2-tong1.wu@intel.com> (raw)
In-Reply-To: <20230425072620.512-1-tong1.wu@intel.com>

When both derive_device_type and device context are not
presented during hw->hw map, the hwmap filter should be
able to retrieve AVHWDeviceType from outlink->format and create
corresponding hwdevice context.

Signed-off-by: Tong Wu <tong1.wu@intel.com>
---
 libavfilter/vf_hwmap.c | 35 ++++++++++++++++++++++-------------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c
index e246b22603..e5b40233b2 100644
--- a/libavfilter/vf_hwmap.c
+++ b/libavfilter/vf_hwmap.c
@@ -70,16 +70,31 @@ static int hwmap_config_output(AVFilterLink *outlink)
     device_is_derived = 0;
 
     if (inlink->hw_frames_ctx) {
+        enum AVHWDeviceType type;
         hwfc = (AVHWFramesContext*)inlink->hw_frames_ctx->data;
 
-        if (ctx->derive_device_type) {
-            enum AVHWDeviceType type;
+        desc = av_pix_fmt_desc_get(outlink->format);
+        if (!desc) {
+            err = AVERROR(EINVAL);
+            goto fail;
+        }
 
-            type = av_hwdevice_find_type_by_name(ctx->derive_device_type);
-            if (type == AV_HWDEVICE_TYPE_NONE) {
-                av_log(avctx, AV_LOG_ERROR, "Invalid device type.\n");
-                err = AVERROR(EINVAL);
-                goto fail;
+        if (ctx->derive_device_type || (!device && (desc->flags & AV_PIX_FMT_FLAG_HWACCEL))) {
+            if (ctx->derive_device_type) {
+                type = av_hwdevice_find_type_by_name(ctx->derive_device_type);
+                if (type == AV_HWDEVICE_TYPE_NONE) {
+                    av_log(avctx, AV_LOG_ERROR, "Invalid device type.\n");
+                    err = AVERROR(EINVAL);
+                    goto fail;
+                }
+            } else {
+                type = av_hwdevice_get_type_by_pix_fmt(outlink->format);
+                if (type == AV_HWDEVICE_TYPE_NONE) {
+                    av_log(avctx, AV_LOG_ERROR, "Could not get device type from "
+                        "format %s.\n", av_get_pix_fmt_name(outlink->format));
+                    err = AVERROR(EINVAL);
+                    goto fail;
+                }
             }
 
             err = av_hwdevice_ctx_create_derived(&device, type,
@@ -92,12 +107,6 @@ static int hwmap_config_output(AVFilterLink *outlink)
             device_is_derived = 1;
         }
 
-        desc = av_pix_fmt_desc_get(outlink->format);
-        if (!desc) {
-            err = AVERROR(EINVAL);
-            goto fail;
-        }
-
         if (inlink->format == hwfc->format &&
             (desc->flags & AV_PIX_FMT_FLAG_HWACCEL) &&
             !ctx->reverse) {
-- 
2.39.1.windows.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-04-25  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  7:26 [FFmpeg-devel] [PATCH v5 1/5] avutil/hwcontext: add a function to get the AVHWDeviceType Tong Wu
2023-04-25  7:26 ` Tong Wu [this message]
2023-04-25  7:26 ` [FFmpeg-devel] [PATCH v5 3/5] lavfi/avfiltergraph: move convert codes into functions Tong Wu
2023-04-25  7:26 ` [FFmpeg-devel] [PATCH v5 4/5] lavfi/format: wrap auto filters into structures Tong Wu
2023-05-13  6:33   ` Paul B Mahol
2023-05-25  7:06     ` Wu, Tong1
2023-06-07  8:42       ` Wu, Tong1
2023-04-25  7:26 ` [FFmpeg-devel] [PATCH v5 5/5] lavfi/format: add a hwmap auto conversion filter Tong Wu
2023-06-07  8:51   ` Marvin Scholz
2023-06-08  8:47     ` Wu, Tong1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230425072620.512-2-tong1.wu@intel.com \
    --to=tong1.wu-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=tong1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git