From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/6] avcodec/apedec: Move pointer instead of copying each element in delay in long_filter_high_3800()
Date: Mon, 24 Apr 2023 00:32:32 +0200
Message-ID: <20230423223236.375-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20230423223236.375-1-michael@niedermayer.cc>
~1000 -> 930 cycles
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/apedec.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index c08d13d6c2..40cd78a991 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -944,7 +944,7 @@ static void long_filter_high_3800(int32_t *buffer, int order, int shift, int len
{
int i, j;
int32_t dotprod, sign;
- int32_t coeffs[256], delay[256];
+ int32_t coeffs[256], delay[256+256], *delayp = delay;
if (order >= length)
return;
@@ -956,13 +956,16 @@ static void long_filter_high_3800(int32_t *buffer, int order, int shift, int len
dotprod = 0;
sign = APESIGN(buffer[i]);
for (j = 0; j < order; j++) {
- dotprod += delay[j] * (unsigned)coeffs[j];
- coeffs[j] += ((delay[j] >> 31) | 1) * sign;
+ dotprod += delayp[j] * (unsigned)coeffs[j];
+ coeffs[j] += ((delayp[j] >> 31) | 1) * sign;
}
buffer[i] -= (unsigned)(dotprod >> shift);
- for (j = 0; j < order - 1; j++)
- delay[j] = delay[j + 1];
- delay[order - 1] = buffer[i];
+ delayp ++;
+ delayp[order - 1] = buffer[i];
+ if (delayp - delay == 256) {
+ memcpy(delay, delayp, sizeof(*delay)*256);
+ delayp = delay;
+ }
}
}
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-23 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 22:32 [FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust threshold for FMVC Michael Niedermayer
2023-04-23 22:32 ` Michael Niedermayer [this message]
2023-04-23 22:32 ` [FFmpeg-devel] [PATCH 3/6] avcodec/apedec: Factor constant sign out of loop in long_filter_high_3800() Michael Niedermayer
2023-04-23 22:32 ` [FFmpeg-devel] [PATCH 4/6] tools/target_dec_fuzzer: Adjust threshold for APE Michael Niedermayer
2023-04-23 22:32 ` [FFmpeg-devel] [PATCH 5/6] avcodec/cavsdec: Check bits left before picture allocation Michael Niedermayer
2023-04-23 22:32 ` [FFmpeg-devel] [PATCH 6/6] avcodec/bonk: decode multiple passes in intlist_read() at once Michael Niedermayer
2023-04-30 20:03 ` [FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust threshold for FMVC Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230423223236.375-2-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git