From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0CB4145F6B for ; Wed, 19 Apr 2023 20:53:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 79BBD68BE9E; Wed, 19 Apr 2023 23:53:10 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A35C68BE63 for ; Wed, 19 Apr 2023 23:53:03 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 289AF20007 for ; Wed, 19 Apr 2023 20:53:02 +0000 (UTC) Date: Wed, 19 Apr 2023 22:53:02 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230419205302.GU275832@pb2> References: <20230419194832.757-1-anton@khirnov.net> MIME-Version: 1.0 In-Reply-To: <20230419194832.757-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0142761184852827831==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0142761184852827831== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jllsgs4PL/sXFNaa" Content-Disposition: inline --jllsgs4PL/sXFNaa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote: > When an encoder exports sum-of-squared-differences information in > encoded packets, print_report() will print PSNR information in the > status line. However, > * the code computing PSNR assumes 8bit 420 video and prints incorrect > values otherwise; there are no issues on trac about this Are the values in the "otherwise" case maybe good enough so they worked for people with noone noticing ? > * only a few encoders (namely aom, vpx, mpegvideo, snow) export this > information; other often-used encoders such as libx26[45] do not > export this, even though they could >=20 > This suggests that this feature is not useful and it is better to remove > it rather than spend effort on fixing it. > --- > I needed to resolve this code's interaction with encoders as a part of > my multithreading work and spent a few hours on it. Making it work > correctly in all cases seems nontrivial and duplicates a lot of the > logic from vf_psnr. Can anything missing in vf_psnr be added into it and then vf_psnr used ? I agree that duplicating PSNR code and logic is bad >=20 > Given that nobody ever noticed that it's broken for everything other > than YUV420P, or bothered adding support in libx264 strongly suggests to > me that nobody cares about this and it can be safely dropped. >=20 > Anyone against? [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire --jllsgs4PL/sXFNaa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZEBUqQAKCRBhHseHBAsP q4UgAJ97onejC0uLHeBS1ODsbduxZWEEwQCfTDuwRmpgBOpAGgKQO6BV1cfy/dE= =H0sP -----END PGP SIGNATURE----- --jllsgs4PL/sXFNaa-- --===============0142761184852827831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0142761184852827831==--