From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC/PATCH] fftools/ffmpeg: stop printing PSNR information in status report
Date: Wed, 19 Apr 2023 22:53:02 +0200
Message-ID: <20230419205302.GU275832@pb2> (raw)
In-Reply-To: <20230419194832.757-1-anton@khirnov.net>
[-- Attachment #1.1: Type: text/plain, Size: 1559 bytes --]
On Wed, Apr 19, 2023 at 09:48:32PM +0200, Anton Khirnov wrote:
> When an encoder exports sum-of-squared-differences information in
> encoded packets, print_report() will print PSNR information in the
> status line. However,
> * the code computing PSNR assumes 8bit 420 video and prints incorrect
> values otherwise; there are no issues on trac about this
Are the values in the "otherwise" case maybe good enough so they
worked for people with noone noticing ?
> * only a few encoders (namely aom, vpx, mpegvideo, snow) export this
> information; other often-used encoders such as libx26[45] do not
> export this, even though they could
>
> This suggests that this feature is not useful and it is better to remove
> it rather than spend effort on fixing it.
> ---
> I needed to resolve this code's interaction with encoders as a part of
> my multithreading work and spent a few hours on it. Making it work
> correctly in all cases seems nontrivial and duplicates a lot of the
> logic from vf_psnr.
Can anything missing in vf_psnr be added into it and then vf_psnr used ?
I agree that duplicating PSNR code and logic is bad
>
> Given that nobody ever noticed that it's broken for everything other
> than YUV420P, or bothered adding support in libx264 strongly suggests to
> me that nobody cares about this and it can be safely dropped.
>
> Anyone against?
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-19 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 19:48 Anton Khirnov
2023-04-19 20:53 ` Michael Niedermayer [this message]
2023-04-19 21:06 ` Anton Khirnov
2023-04-19 22:12 ` Michael Niedermayer
2023-04-20 6:42 ` Anton Khirnov
2023-04-22 15:41 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419205302.GU275832@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git