From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81AA845F02 for ; Mon, 17 Apr 2023 23:18:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4251D68BDFF; Tue, 18 Apr 2023 02:18:29 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FB11689257 for ; Tue, 18 Apr 2023 02:18:22 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E624D60003; Mon, 17 Apr 2023 23:18:21 +0000 (UTC) Date: Tue, 18 Apr 2023 01:18:20 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230417231820.GM275832@pb2> References: <20230416222518.21308-1-michael@niedermayer.cc> <20230416222518.21308-3-michael@niedermayer.cc> <168172778665.3843.7055261507093326884@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <168172778665.3843.7055261507093326884@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Vignesh Venkatasubramanian Content-Type: multipart/mixed; boundary="===============0914546651537807273==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0914546651537807273== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7vLGWvOrvbSM0Ba8" Content-Disposition: inline --7vLGWvOrvbSM0Ba8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 17, 2023 at 12:36:26PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-04-17 00:25:16) > > Fixes: memleak > > Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-66740= 82962997248 > >=20 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mov.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 057fd872b10..6853bb324cf 100644 > > --- a/libavformat/mov.c > > +++ b/libavformat/mov.c > > @@ -7777,7 +7777,7 @@ static int mov_read_iloc(MOVContext *c, AVIOConte= xt *pb, MOVAtom atom) > > return 0; > > } > > =20 > > - if (c->fc->nb_streams) { > > + if (c->fc->nb_streams || c->avif_info) { >=20 > This first condition is now redundant, is it not? Iam not sure what exactly happens if a trak occurs before=20 Iam also not sure what happens if multiple meta tags occur triggering the avif stream addition, i may be missing something but the code seems not to expect that Adding the author of this code to CC thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a rich man's house there is no place to spit but his face. -- Diogenes of Sinope --7vLGWvOrvbSM0Ba8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZD3TuAAKCRBhHseHBAsP q9yVAJ9r8qDM/bKw656jEnxU8nfKdege+wCfdrqukGK7VKk7c4PzVJwewf5lAqQ= =LVXV -----END PGP SIGNATURE----- --7vLGWvOrvbSM0Ba8-- --===============0914546651537807273== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0914546651537807273==--