From: James Almer <jamrial@gmail.com> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avutil/frame: change the type of the crop fields to unsigned in the next major bump Date: Mon, 17 Apr 2023 12:34:08 -0300 Message-ID: <20230417153408.1225-1-jamrial@gmail.com> (raw) size_t is unnecessarily big on 64bit arches when width and height are ints. Signed-off-by: James Almer <jamrial@gmail.com> --- libavutil/frame.h | 7 +++++++ libavutil/version.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index f85d630c5c..e10a1c65e3 100644 --- a/libavutil/frame.h +++ b/libavutil/frame.h @@ -722,10 +722,17 @@ typedef struct AVFrame { * the frame intended for presentation. * @{ */ +#if FF_API_CROP_SIZE_T size_t crop_top; size_t crop_bottom; size_t crop_left; size_t crop_right; +#else + unsigned int crop_top; + unsigned int crop_bottom; + unsigned int crop_left; + unsigned int crop_right; +#endif /** * @} */ diff --git a/libavutil/version.h b/libavutil/version.h index 40f92af055..a974890d1f 100644 --- a/libavutil/version.h +++ b/libavutil/version.h @@ -115,6 +115,7 @@ #define FF_API_FRAME_PICTURE_NUMBER (LIBAVUTIL_VERSION_MAJOR < 59) #define FF_API_HDR_VIVID_THREE_SPLINE (LIBAVUTIL_VERSION_MAJOR < 59) #define FF_API_FRAME_PKT (LIBAVUTIL_VERSION_MAJOR < 59) +#define FF_API_CROP_SIZE_T (LIBAVUTIL_VERSION_MAJOR < 59) /** * @} -- 2.40.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-04-17 15:34 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-17 15:34 James Almer [this message] 2023-04-17 17:07 ` Anton Khirnov 2023-04-17 17:20 ` Marton Balint
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230417153408.1225-1-jamrial@gmail.com \ --to=jamrial@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git