From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/5] avformat/avs: unref packet after avs_read_audio_packet() fail
Date: Mon, 17 Apr 2023 00:25:15 +0200
Message-ID: <20230416222518.21308-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20230416222518.21308-1-michael@niedermayer.cc>
Fixes: memleak
Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_dem_AVS_fuzzer-6738814988320768
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavformat/avs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/avs.c b/libavformat/avs.c
index ab47980a11c..2ce8b19c412 100644
--- a/libavformat/avs.c
+++ b/libavformat/avs.c
@@ -156,9 +156,11 @@ static int avs_read_packet(AVFormatContext * s, AVPacket * pkt)
uint8_t palette[4 + 3 * 256];
int ret;
- if (avs->remaining_audio_size > 0)
+ if (avs->remaining_audio_size > 0) {
if (avs_read_audio_packet(s, pkt) > 0)
return 0;
+ av_packet_unref(pkt);
+ }
while (1) {
if (avs->remaining_frame_size <= 0) {
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-16 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 22:25 [FFmpeg-devel] [PATCH 1/5] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in Michael Niedermayer
2023-04-16 22:25 ` Michael Niedermayer [this message]
2023-04-16 22:25 ` [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc Michael Niedermayer
2023-04-17 10:36 ` Anton Khirnov
2023-04-17 23:18 ` Michael Niedermayer
2023-04-25 22:22 ` Vignesh Venkatasubramanian
2023-09-29 19:21 ` Michael Niedermayer
2023-10-03 22:56 ` Vignesh Venkat via ffmpeg-devel
2023-10-04 4:22 ` Vignesh Venkat via ffmpeg-devel
2023-04-16 22:25 ` [FFmpeg-devel] [PATCH 4/5] avcodec/hevc_ps: Use get_ue_golomb() instead of get_ue_golomb_long() for depth Michael Niedermayer
2023-04-16 22:25 ` [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_ps: Check depth to be within 8 to 16 Michael Niedermayer
2023-04-30 22:32 ` Michael Niedermayer
2023-04-16 22:57 ` [FFmpeg-devel] [PATCH 1/5] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in James Almer
2023-04-17 11:26 ` Michael Niedermayer
2023-04-17 11:28 ` James Almer
2023-04-17 11:34 ` Michael Niedermayer
2023-04-17 17:13 ` Marton Balint
2023-04-17 17:23 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230416222518.21308-2-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git