From: Steven Liu <lq@chinaffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Steven Liu <lq@chinaffmpeg.org>
Subject: [FFmpeg-devel] [PATCH v6 2/4] avformat/flvdec: support demux HEVC in Enhancing FLV
Date: Wed, 12 Apr 2023 15:30:58 +0800
Message-ID: <20230412073100.53743-2-lq@chinaffmpeg.org> (raw)
In-Reply-To: <20230412073100.53743-1-lq@chinaffmpeg.org>
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
libavformat/flvdec.c | 63 +++++++++++++++++++++++++++++++++++++++-----
1 file changed, 56 insertions(+), 7 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
index d83edff727..8060c43772 100644
--- a/libavformat/flvdec.c
+++ b/libavformat/flvdec.c
@@ -79,6 +79,8 @@ typedef struct FLVContext {
int64_t last_ts;
int64_t time_offset;
int64_t time_pos;
+
+ uint8_t exheader;
} FLVContext;
/* AMF date type */
@@ -302,13 +304,26 @@ static void flv_set_audio_codec(AVFormatContext *s, AVStream *astream,
}
}
-static int flv_same_video_codec(AVCodecParameters *vpar, int flags)
+static int flv_same_video_codec(AVFormatContext *s, AVCodecParameters *vpar, int flags)
{
int flv_codecid = flags & FLV_VIDEO_CODECID_MASK;
+ FLVContext *flv = s->priv_data;
if (!vpar->codec_id && !vpar->codec_tag)
return 1;
+ if (flv->exheader) {
+ uint8_t *codec_id_str = (uint8_t *)s->pb->buf_ptr;
+ uint32_t codec_id = codec_id_str[3] | codec_id_str[2] << 8 | codec_id_str[1] << 16 | codec_id_str[0] << 24;
+ switch(codec_id) {
+ case MKBETAG('h', 'v', 'c', '1'):
+ flv_codecid = FLV_CODECID_HEVC;
+ break;
+ default:
+ break;
+ }
+ }
+
switch (flv_codecid) {
case FLV_CODECID_H263:
return vpar->codec_id == AV_CODEC_ID_FLV1;
@@ -322,6 +337,8 @@ static int flv_same_video_codec(AVCodecParameters *vpar, int flags)
return vpar->codec_id == AV_CODEC_ID_VP6A;
case FLV_CODECID_H264:
return vpar->codec_id == AV_CODEC_ID_H264;
+ case FLV_CODECID_HEVC:
+ return vpar->codec_id == AV_CODEC_ID_HEVC;
default:
return vpar->codec_tag == flv_codecid;
}
@@ -331,9 +348,23 @@ static int flv_set_video_codec(AVFormatContext *s, AVStream *vstream,
int flv_codecid, int read)
{
FFStream *const vstreami = ffstream(vstream);
+ FLVContext *flv = s->priv_data;
int ret = 0;
AVCodecParameters *par = vstream->codecpar;
enum AVCodecID old_codec_id = vstream->codecpar->codec_id;
+ flv_codecid &= FLV_VIDEO_CODECID_MASK;
+
+ if (flv->exheader) {
+ uint32_t codec_id = avio_rb32(s->pb);
+
+ switch(codec_id) {
+ case MKBETAG('h', 'v', 'c', '1'):
+ flv_codecid = FLV_CODECID_HEVC;
+ break;
+ default:
+ break;
+ }
+ }
switch (flv_codecid) {
case FLV_CODECID_H263:
par->codec_id = AV_CODEC_ID_FLV1;
@@ -372,6 +403,11 @@ static int flv_set_video_codec(AVFormatContext *s, AVStream *vstream,
par->codec_id = AV_CODEC_ID_MPEG4;
ret = 3;
break;
+ case FLV_CODECID_HEVC:
+ par->codec_id = AV_CODEC_ID_HEVC;
+ vstreami->need_parsing = AVSTREAM_PARSE_HEADERS;
+ ret = 3;
+ break;
default:
avpriv_request_sample(s, "Video codec (%x)", flv_codecid);
par->codec_tag = flv_codecid;
@@ -796,6 +832,7 @@ static int flv_read_header(AVFormatContext *s)
s->start_time = 0;
flv->sum_flv_tag_size = 0;
flv->last_keyframe_stream_index = -1;
+ flv->exheader = 0;
return 0;
}
@@ -1071,6 +1108,11 @@ retry:
} else if (type == FLV_TAG_TYPE_VIDEO) {
stream_type = FLV_STREAM_TYPE_VIDEO;
flags = avio_r8(s->pb);
+ /*
+ * Reference Enhancing FLV 2023-03-v1.0.0-B.8
+ * https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf
+ * */
+ flv->exheader = (flags >> 7) & 1;
size--;
if ((flags & FLV_VIDEO_FRAMETYPE_MASK) == FLV_FRAME_VIDEO_INFO_CMD)
goto skip;
@@ -1129,7 +1171,7 @@ skip:
break;
} else if (stream_type == FLV_STREAM_TYPE_VIDEO) {
if (st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO &&
- (s->video_codec_id || flv_same_video_codec(st->codecpar, flags)))
+ (s->video_codec_id || flv_same_video_codec(s, st->codecpar, flags)))
break;
} else if (stream_type == FLV_STREAM_TYPE_SUBTITLE) {
if (st->codecpar->codec_type == AVMEDIA_TYPE_SUBTITLE)
@@ -1230,7 +1272,7 @@ retry_duration:
avcodec_parameters_free(&par);
}
} else if (stream_type == FLV_STREAM_TYPE_VIDEO) {
- int ret = flv_set_video_codec(s, st, flags & FLV_VIDEO_CODECID_MASK, 1);
+ int ret = flv_set_video_codec(s, st, flags, 1);
if (ret < 0)
return ret;
size -= ret;
@@ -1242,8 +1284,14 @@ retry_duration:
if (st->codecpar->codec_id == AV_CODEC_ID_AAC ||
st->codecpar->codec_id == AV_CODEC_ID_H264 ||
- st->codecpar->codec_id == AV_CODEC_ID_MPEG4) {
- int type = avio_r8(s->pb);
+ st->codecpar->codec_id == AV_CODEC_ID_MPEG4 ||
+ st->codecpar->codec_id == AV_CODEC_ID_HEVC) {
+ int type = 0;
+ if (flv->exheader) {
+ type = flags & 0x0F;
+ } else {
+ type = avio_r8(s->pb);
+ }
size--;
if (size < 0) {
@@ -1251,7 +1299,8 @@ retry_duration:
goto leave;
}
- if (st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_MPEG4) {
+ if (st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_MPEG4
+ || (st->codecpar->codec_id == AV_CODEC_ID_HEVC && (flags & 0x0F))) {
// sign extension
int32_t cts = (avio_rb24(s->pb) + 0xff800000) ^ 0xff800000;
pts = av_sat_add64(dts, cts);
@@ -1267,7 +1316,7 @@ retry_duration:
}
}
if (type == 0 && (!st->codecpar->extradata || st->codecpar->codec_id == AV_CODEC_ID_AAC ||
- st->codecpar->codec_id == AV_CODEC_ID_H264)) {
+ st->codecpar->codec_id == AV_CODEC_ID_H264 || st->codecpar->codec_id == AV_CODEC_ID_HEVC)) {
AVDictionaryEntry *t;
if (st->codecpar->extradata) {
--
2.40.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-12 7:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 12:12 [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-04-06 12:12 ` [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: support demux HEVC in Enhancing FLV Steven Liu
2023-04-06 12:18 ` James Almer
2023-04-06 12:24 ` [FFmpeg-devel] [PATCH v2 " Steven Liu
2023-04-06 12:30 ` Martin Storsjö
2023-04-06 12:38 ` Steven Liu
2023-04-06 13:19 ` Martin Storsjö
2023-04-07 2:51 ` Steven Liu
2023-04-07 18:54 ` Martin Storsjö
2023-04-08 3:22 ` [FFmpeg-devel] [PATCH v3 1/2] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-04-08 3:22 ` [FFmpeg-devel] [PATCH v3 2/2] avformat/flvdec: support demux HEVC in Enhanced FLV Steven Liu
2023-04-06 12:30 ` [FFmpeg-devel] [PATCH 2/2] avformat/flvdec: support demux HEVC in Enhancing FLV Steven Liu
2023-04-06 14:44 ` [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: Add support for HEVC over flv in muxer Lance Wang
2023-04-06 15:10 ` Gyan Doshi
2023-04-06 15:32 ` Jean-Baptiste Kempf
2023-04-06 17:03 ` Jan Ekström
2023-04-11 8:56 ` Neal Gompa
2023-04-11 9:24 ` Steven Liu
2023-04-12 1:26 ` Neal Gompa
2023-04-12 3:10 ` Steven Liu
2023-04-12 4:27 ` [FFmpeg-devel] [PATCH v4 1/4] " Steven Liu
2023-04-12 4:27 ` [FFmpeg-devel] [PATCH v4 2/4] avformat/flvdec: support demux HEVC in Enhanced FLV Steven Liu
2023-04-12 4:27 ` [FFmpeg-devel] [PATCH v4 3/4] avformat/flvenc: support mux av1 " Steven Liu
2023-04-12 4:27 ` [FFmpeg-devel] [PATCH v4 4/4] avformat/flvdec: support demux " Steven Liu
2023-04-12 4:32 ` [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-04-12 4:42 ` Steven Liu
2023-04-12 4:37 ` [FFmpeg-devel] [PATCH v5 1/4] " Steven Liu
2023-04-12 4:37 ` [FFmpeg-devel] [PATCH v5 2/4] avformat/flvdec: support demux HEVC in Enhancing FLV Steven Liu
2023-04-12 4:37 ` [FFmpeg-devel] [PATCH v5 3/4] avformat/flvenc: support mux av1 in Enhanced FLV Steven Liu
2023-04-12 4:37 ` [FFmpeg-devel] [PATCH v5 4/4] avformat/flvdec: support demux " Steven Liu
2023-04-12 7:30 ` [FFmpeg-devel] [PATCH v6 1/4] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
2023-04-12 7:30 ` Steven Liu [this message]
2023-04-12 7:30 ` [FFmpeg-devel] [PATCH v6 3/4] avformat/flvenc: support mux av1 in Enhanced FLV Steven Liu
2023-04-12 7:31 ` [FFmpeg-devel] [PATCH v6 4/4] avformat/flvdec: support demux " Steven Liu
2023-04-13 0:41 ` [FFmpeg-devel] [PATCH v6 1/4] avformat/flvenc: Add support for HEVC over flv in muxer Jean-Baptiste Kempf
2023-04-13 6:29 ` [FFmpeg-devel] [PATCH v7 " Steven Liu
2023-04-13 6:29 ` [FFmpeg-devel] [PATCH v7 2/4] avformat/flvdec: support demux hevc in enhanced flv Steven Liu
2023-04-13 6:29 ` [FFmpeg-devel] [PATCH v7 3/4] avformat/flvenc: support mux av1 " Steven Liu
2023-04-13 6:29 ` [FFmpeg-devel] [PATCH v7 4/4] avformat/flvdec: support demux " Steven Liu
2023-04-13 6:41 ` [FFmpeg-devel] [PATCH v6 1/4] avformat/flvenc: Add support for HEVC over flv in muxer Steven Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412073100.53743-2-lq@chinaffmpeg.org \
--to=lq@chinaffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git