From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 300F845D7C for ; Sun, 9 Apr 2023 23:43:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F04F68BBDE; Mon, 10 Apr 2023 02:43:04 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D04A6881BA for ; Mon, 10 Apr 2023 02:42:58 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 5DC83240003 for ; Sun, 9 Apr 2023 23:42:56 +0000 (UTC) Date: Mon, 10 Apr 2023 01:42:56 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230409234256.GG1164690@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/amv: use correct quantize tables X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6912581604999024051==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6912581604999024051== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nE/5a/j5SCML90Nq" Content-Disposition: inline --nE/5a/j5SCML90Nq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 09, 2023 at 04:37:49PM +0800, AlexGuo1998 wrote: > So sorry that gmail trashed the patch. Re-sent as an attachment. > From 14910cef473a2858d5cf5e3bf855730762456de1 Mon Sep 17 00:00:00 2001 > From: AlexGuo1998 > Date: Sun, 9 Apr 2023 15:57:05 +0800 > Subject: [PATCH] avcodec/amv: use correct quantize tables >=20 > The official encoder has a mode to generate mjpeg AVI files, which > embeds the correct quantize table. Change the table we use (both encoder > and decoder) to match that. >=20 > Signed-off-by: AlexGuo1998 > --- > libavcodec/mpegvideo_enc.c | 16 +++++++--------- > libavcodec/sp5x.h | 21 +++++++++++++++++++++ > libavcodec/sp5xdec.c | 9 +++++++-- > 3 files changed, 35 insertions(+), 11 deletions(-) decoder and encoder changes should be in seperate patches and the version should be increased for encoder changes so any software reading a file can from a bitstream version metadata indentify it. For this to work of course the version first needs to be stored. So one should check LIBAVCODEC_IDENT is stored This would then also allow the decoder to match the encoder optimally thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2 --nE/5a/j5SCML90Nq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZDNNewAKCRBhHseHBAsP q+o0AJ9Oz4R6ud+2IVOtwzQDPI+t62RB5ACgh9SOfrHgLo/Uv04ZU4cGdnNFtjo= =+Ysn -----END PGP SIGNATURE----- --nE/5a/j5SCML90Nq-- --===============6912581604999024051== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6912581604999024051==--