On Sun, Apr 09, 2023 at 04:37:49PM +0800, AlexGuo1998 wrote: > So sorry that gmail trashed the patch. Re-sent as an attachment. > From 14910cef473a2858d5cf5e3bf855730762456de1 Mon Sep 17 00:00:00 2001 > From: AlexGuo1998 > Date: Sun, 9 Apr 2023 15:57:05 +0800 > Subject: [PATCH] avcodec/amv: use correct quantize tables > > The official encoder has a mode to generate mjpeg AVI files, which > embeds the correct quantize table. Change the table we use (both encoder > and decoder) to match that. > > Signed-off-by: AlexGuo1998 > --- > libavcodec/mpegvideo_enc.c | 16 +++++++--------- > libavcodec/sp5x.h | 21 +++++++++++++++++++++ > libavcodec/sp5xdec.c | 9 +++++++-- > 3 files changed, 35 insertions(+), 11 deletions(-) decoder and encoder changes should be in seperate patches and the version should be increased for encoder changes so any software reading a file can from a bitstream version metadata indentify it. For this to work of course the version first needs to be stored. So one should check LIBAVCODEC_IDENT is stored This would then also allow the decoder to match the encoder optimally thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2