From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B022945D94 for ; Sun, 9 Apr 2023 17:20:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 04EA668BCE7; Sun, 9 Apr 2023 20:20:13 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1F3C689CE2 for ; Sun, 9 Apr 2023 20:20:06 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id BFE24FF806 for ; Sun, 9 Apr 2023 17:20:05 +0000 (UTC) Date: Sun, 9 Apr 2023 19:20:04 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230409172004.GD1164690@pb2> References: <20230408183724.12479-1-cus@passwd.hu> <20230408211411.GC4538@pb2> <9258ec2c-6635-1edc-f695-1cc2629c6ac8@passwd.hu> MIME-Version: 1.0 In-Reply-To: <9258ec2c-6635-1edc-f695-1cc2629c6ac8@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: remove hack breaking creation time parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3252206395003605703==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3252206395003605703== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bnBIwIKtMHAVL+3z" Content-Disposition: inline --bnBIwIKtMHAVL+3z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 09, 2023 at 03:49:33PM +0200, Marton Balint wrote: >=20 >=20 > On Sat, 8 Apr 2023, Michael Niedermayer wrote: >=20 > > On Sat, Apr 08, 2023 at 08:37:24PM +0200, Marton Balint wrote: > > > Commit 23eeffcd48a15e73fb2649b712870b6d101c5471 added a hack to suppo= rt invalid > > > files where the creation date was encoded as a classic unix timestamp= =2E This > > > broke however valid files having creation dates before the unix epoch. > > >=20 > > > Signed-off-by: Marton Balint > > > --- > > > libavformat/mov.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > >=20 > > This results in: > > @@ -1,11 +1,11 @@ > > - creation_time : 2012-06-20T20:58:31.000000Z > > - creation_time : 2012-06-20T20:58:31.000000Z > > - creation_time : 2012-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > >=20 > > Are you sure that 1946 is the correct creation date and not 2012 ? >=20 > If you are referring to the file in ticket #1471, yes, 1946 is consistent > with what mediainfo shows for creation time. Obviously 1946 was not the > intended creation time, but that does not warrant us to break files where > 1946 is the *intended* creation time. Proper way to fix the original issue > would be to detect the device and software version which produces the > invalid files, and only apply the hack there. But I don't think that is > doable here, the file does not seem to contain any device or software > information. what do you mean by intended creation time? the file format did not exist in 1946. and all the codecs also didnt exist so when you encounter a file that says its from that time it must be crafted later and backdated or that bug. we know the bug is a real thing do you want to support crafted and backdatred files? if so can you explain the usecase for that ? maybe iam missing something thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only have a finite lifespan? No, its going to go on forever, its just that you wont like living in it. -- Hiranya Peiri --bnBIwIKtMHAVL+3z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZDLzvwAKCRBhHseHBAsP q8W9AJ9JtJDY7NaDNybQRB6j2hZBGGjgCQCeNE8ngJg8LmvWnHRI+vJxKsstGt0= =yQQR -----END PGP SIGNATURE----- --bnBIwIKtMHAVL+3z-- --===============3252206395003605703== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3252206395003605703==--