Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zane van Iperen <zane@zanevaniperen.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 3/3] avcodec/brenderpix: use BR_PMT_* defines for pixelmap types
Date: Sun,  9 Apr 2023 22:25:43 +1000
Message-ID: <20230409122543.223974-3-zane@zanevaniperen.com> (raw)
In-Reply-To: <20230409122543.223974-1-zane@zanevaniperen.com>

Taken from the BRender source tree at [1].

[1]: https://github.com/crocguy0688/CrocDE-BRender/blob/master/brender/inc/pixelmap.h#L19
---
 libavcodec/brenderpix.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c
index 52765f0c00..baadc08c7f 100644
--- a/libavcodec/brenderpix.c
+++ b/libavcodec/brenderpix.c
@@ -32,6 +32,20 @@
 #define HEADER2_CHUNK    0x3D
 #define IMAGE_DATA_CHUNK 0x21
 
+/*
+ * BRender pixelmap constants taken from inc/pixelmap.h
+ * https://github.com/crocguy0688/CrocDE-BRender/blob/e605abee4e96e4492f2f8c7ea5e5e5bd31bcd1e3/brender/inc/pixelmap.h
+ */
+enum {
+    BR_PMT_INDEX_8   =  3,
+    BR_PMT_RGB_555   =  4,
+    BR_PMT_RGB_565   =  5,
+    BR_PMT_RGB_888   =  6,
+    BR_PMT_RGBX_888  =  7,
+    BR_PMT_RGBA_8888 =  8,
+    BR_PMT_BGR_555   = 17,
+};
+
 /* In 8-bit colour mode, 256 colours are available at any time. Which 256
  * colours are available is determined by the contents of the hardware palette
  * (or CLUT). In this case, the palette supplied with BRender (std.pal) has
@@ -171,31 +185,31 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame,
         return ret;
     }
     switch (hdr.format) {
-    case 3:
+    case BR_PMT_INDEX_8:
         avctx->pix_fmt = AV_PIX_FMT_PAL8;
         bytes_pp = 1;
         break;
-    case 4:
+    case BR_PMT_RGB_555:
         avctx->pix_fmt = AV_PIX_FMT_RGB555BE;
         bytes_pp = 2;
         break;
-    case 5:
+    case BR_PMT_RGB_565:
         avctx->pix_fmt = AV_PIX_FMT_RGB565BE;
         bytes_pp = 2;
         break;
-    case 6:
+    case BR_PMT_RGB_888:
         avctx->pix_fmt = AV_PIX_FMT_RGB24;
         bytes_pp = 3;
         break;
-    case 7:
+    case BR_PMT_RGBX_888:
         avctx->pix_fmt = AV_PIX_FMT_0RGB;
         bytes_pp = 4;
         break;
-    case 8: // ARGB
+    case BR_PMT_RGBA_8888: /* It says RGBA, but it's actually ARGB. */
         avctx->pix_fmt = AV_PIX_FMT_ARGB;
         bytes_pp = 4;
         break;
-    case 17:
+    case BR_PMT_BGR_555:
         avctx->pix_fmt = AV_PIX_FMT_BGR555BE;
         bytes_pp = 2;
         break;
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2023-04-09 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-09 12:25 [FFmpeg-devel] [PATCH 1/3] avcodec/brenderpix: remove support for type 18 pixelmaps Zane van Iperen
2023-04-09 12:25 ` [FFmpeg-devel] [PATCH 2/3] avcodec/brenderpix: support BGR555BE (type 17) Zane van Iperen
2023-04-09 12:25 ` Zane van Iperen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230409122543.223974-3-zane@zanevaniperen.com \
    --to=zane@zanevaniperen.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git