From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: remove hack breaking creation time parsing
Date: Sat, 8 Apr 2023 23:14:11 +0200
Message-ID: <20230408211411.GC4538@pb2> (raw)
In-Reply-To: <20230408183724.12479-1-cus@passwd.hu>
[-- Attachment #1.1: Type: text/plain, Size: 1079 bytes --]
On Sat, Apr 08, 2023 at 08:37:24PM +0200, Marton Balint wrote:
> Commit 23eeffcd48a15e73fb2649b712870b6d101c5471 added a hack to support invalid
> files where the creation date was encoded as a classic unix timestamp. This
> broke however valid files having creation dates before the unix epoch.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> libavformat/mov.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
This results in:
@@ -1,11 +1,11 @@
- creation_time : 2012-06-20T20:58:31.000000Z
- creation_time : 2012-06-20T20:58:31.000000Z
- creation_time : 2012-06-20T20:58:31.000000Z
+ creation_time : 1946-06-20T20:58:31.000000Z
+ creation_time : 1946-06-20T20:58:31.000000Z
+ creation_time : 1946-06-20T20:58:31.000000Z
Are you sure that 1946 is the correct creation date and not 2012 ?
Thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-08 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 18:37 Marton Balint
2023-04-08 21:14 ` Michael Niedermayer [this message]
2023-04-09 13:49 ` Marton Balint
2023-04-09 14:06 ` Anton Khirnov
2023-04-09 17:20 ` Michael Niedermayer
2023-04-09 17:52 ` Marton Balint
2023-04-09 21:27 ` Michael Niedermayer
2023-04-10 19:11 ` Marton Balint
2023-04-10 22:34 ` Michael Niedermayer
2023-04-10 2:44 ` "zhilizhao(赵志立)"
2023-04-10 14:31 ` Michael Niedermayer
2023-04-11 11:46 Bernd Dürrer
2023-04-11 18:15 ` Marton Balint
2023-04-12 8:10 ` Bernd Dürrer
2023-04-12 8:38 ` "zhilizhao(赵志立)"
2023-04-13 10:13 ` Bernd Dürrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408211411.GC4538@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git