* [FFmpeg-devel] [PATCH 1/2] avcodec/brenderpix: support BGR555BE (type 17)
@ 2023-04-07 16:00 Zane van Iperen
2023-04-07 16:00 ` [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch Zane van Iperen
0 siblings, 1 reply; 3+ messages in thread
From: Zane van Iperen @ 2023-04-07 16:00 UTC (permalink / raw)
To: ffmpeg-devel
---
libavcodec/brenderpix.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c
index e95ab3d4af..32e7329105 100644
--- a/libavcodec/brenderpix.c
+++ b/libavcodec/brenderpix.c
@@ -195,6 +195,10 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame,
avctx->pix_fmt = AV_PIX_FMT_ARGB;
bytes_pp = 4;
break;
+ case 17: // BR_PMT_BGR_555
+ avctx->pix_fmt = AV_PIX_FMT_BGR555BE;
+ bytes_pp = 2;
+ break;
case 18:
avctx->pix_fmt = AV_PIX_FMT_YA8;
bytes_pp = 2;
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch
2023-04-07 16:00 [FFmpeg-devel] [PATCH 1/2] avcodec/brenderpix: support BGR555BE (type 17) Zane van Iperen
@ 2023-04-07 16:00 ` Zane van Iperen
2023-04-07 16:15 ` Marton Balint
0 siblings, 1 reply; 3+ messages in thread
From: Zane van Iperen @ 2023-04-07 16:00 UTC (permalink / raw)
To: ffmpeg-devel
---
libavcodec/brenderpix.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c
index 32e7329105..7b5bb7ce52 100644
--- a/libavcodec/brenderpix.c
+++ b/libavcodec/brenderpix.c
@@ -171,27 +171,27 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame,
return ret;
}
switch (hdr.format) {
- case 3:
+ case 3: // BR_PMT_INDEX_8
avctx->pix_fmt = AV_PIX_FMT_PAL8;
bytes_pp = 1;
break;
- case 4:
+ case 4: // BR_PMT_RGB_555
avctx->pix_fmt = AV_PIX_FMT_RGB555BE;
bytes_pp = 2;
break;
- case 5:
+ case 5: // BR_PMT_RGB_565
avctx->pix_fmt = AV_PIX_FMT_RGB565BE;
bytes_pp = 2;
break;
- case 6:
+ case 6: // BR_PMT_RGB_888
avctx->pix_fmt = AV_PIX_FMT_RGB24;
bytes_pp = 3;
break;
- case 7:
+ case 7: // BR_PMT_RGBX_888
avctx->pix_fmt = AV_PIX_FMT_0RGB;
bytes_pp = 4;
break;
- case 8: // ARGB
+ case 8: // BR_PMT_RGBA_8888
avctx->pix_fmt = AV_PIX_FMT_ARGB;
bytes_pp = 4;
break;
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch
2023-04-07 16:00 ` [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch Zane van Iperen
@ 2023-04-07 16:15 ` Marton Balint
0 siblings, 0 replies; 3+ messages in thread
From: Marton Balint @ 2023-04-07 16:15 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sat, 8 Apr 2023, Zane van Iperen wrote:
> ---
> libavcodec/brenderpix.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Just add #defines for the formats, so you don't need to use comments.
Regards,
Marton
>
> diff --git a/libavcodec/brenderpix.c b/libavcodec/brenderpix.c
> index 32e7329105..7b5bb7ce52 100644
> --- a/libavcodec/brenderpix.c
> +++ b/libavcodec/brenderpix.c
> @@ -171,27 +171,27 @@ static int pix_decode_frame(AVCodecContext *avctx, AVFrame *frame,
> return ret;
> }
> switch (hdr.format) {
> - case 3:
> + case 3: // BR_PMT_INDEX_8
> avctx->pix_fmt = AV_PIX_FMT_PAL8;
> bytes_pp = 1;
> break;
> - case 4:
> + case 4: // BR_PMT_RGB_555
> avctx->pix_fmt = AV_PIX_FMT_RGB555BE;
> bytes_pp = 2;
> break;
> - case 5:
> + case 5: // BR_PMT_RGB_565
> avctx->pix_fmt = AV_PIX_FMT_RGB565BE;
> bytes_pp = 2;
> break;
> - case 6:
> + case 6: // BR_PMT_RGB_888
> avctx->pix_fmt = AV_PIX_FMT_RGB24;
> bytes_pp = 3;
> break;
> - case 7:
> + case 7: // BR_PMT_RGBX_888
> avctx->pix_fmt = AV_PIX_FMT_0RGB;
> bytes_pp = 4;
> break;
> - case 8: // ARGB
> + case 8: // BR_PMT_RGBA_8888
> avctx->pix_fmt = AV_PIX_FMT_ARGB;
> bytes_pp = 4;
> break;
> --
> 2.39.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-07 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07 16:00 [FFmpeg-devel] [PATCH 1/2] avcodec/brenderpix: support BGR555BE (type 17) Zane van Iperen
2023-04-07 16:00 ` [FFmpeg-devel] [PATCH 2/2] avcodec/brenderpix: add BR_PMT_* comments to type switch Zane van Iperen
2023-04-07 16:15 ` Marton Balint
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git