From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B70FF45D09 for ; Tue, 4 Apr 2023 17:32:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B889268041B; Tue, 4 Apr 2023 20:32:51 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D104368041B for ; Tue, 4 Apr 2023 20:32:44 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id D3CB020004 for ; Tue, 4 Apr 2023 17:32:43 +0000 (UTC) Date: Tue, 4 Apr 2023 19:32:42 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230404173242.GW1164690@pb2> References: <09775b73ab48e425f3b557aaa8d5847643ebe9b7.camel@haerdin.se> <0b6c3856-082c-cb33-e07c-3adf0502b93c@mediaarea.net> <20230401143739.GD1164690@pb2> <85c1e58e-cc90-5814-cba5-d91201dec993@mediaarea.net> <20230401154301.GF1164690@pb2> <71eaedd7-d771-50a7-ed13-3733b8c2187f@mediaarea.net> <20230402200740.GK1164690@pb2> <7291a984-856c-3cd4-483f-f55f13af6be2@mediaarea.net> <20230404144355.GU1164690@pb2> <4bcc6a3e-d0c8-f7ce-0620-7e9e9e745a5f@mediaarea.net> MIME-Version: 1.0 In-Reply-To: <4bcc6a3e-d0c8-f7ce-0620-7e9e9e745a5f@mediaarea.net> Subject: Re: [FFmpeg-devel] avformat/mxfenc: SMPTE RDD 48:2018 Amd 1:2022 (FFV1 in MXF) support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0807913254473249618==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0807913254473249618== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="doUn1Hmx68n+7ij2" Content-Disposition: inline --doUn1Hmx68n+7ij2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2023 at 04:57:03PM +0200, Jerome Martinez wrote: > On 04/04/2023 16:43, Michael Niedermayer wrote: > > On Mon, Apr 03, 2023 at 12:07:06AM +0200, Jerome Martinez wrote: > > > On 02/04/2023 22:07, Michael Niedermayer wrote: > > >=20 > > > + if (f->version =3D=3D 4 && f->micro_version > 2) { > > > + av_log(f->avctx, AV_LOG_ERROR, "unsupported version 4 mi= cro_version %d\n", > > > + f->micro_version); > > > + return AVERROR_PATCHWELCOME; > > > + } > > > } > > > f->ac =3D get_symbol(c, state, 0); > > you do not know if the decoder will have any problem with these files >=20 >=20 > But you don't don't if the decoder will have no problem, it seems safer to > me to reject something we are not sure to support. "each new micro-version after this first stable variant is compatible with = the previous micro-version: decoders **SHOULD NOT** reject FFV1 bitstreams = due to an unknown micro-version equal or above the micro-version considered= as stable." [...] > libavcodec/ffv1dec.c | 5 +++++ > libavformat/mxfenc.c | 4 ++++ > 2 files changed, 9 insertions(+) > 9b094eb0bd0888725a4a3fac925ef1fa733a48c3 0001-avcodec-ffv1dec-reject-uns= upported-ffv1-versions.patch > From dc0382709e548ef2514198bc866028066134d33e Mon Sep 17 00:00:00 2001 > From: Jerome Martinez > Date: Mon, 3 Apr 2023 00:04:53 +0200 > Subject: [PATCH] avcodec/ffv1dec: reject unsupported ffv1 versions >=20 > And add similar check in libavformat/mxfenc > --- > libavcodec/ffv1dec.c | 5 +++++ > libavformat/mxfenc.c | 4 ++++ > 2 files changed, 9 insertions(+) the patch is mostly ok iam a bit undecided if a decoder change and a muxer bugfix belong in the same patch, so do as you prefer thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Good people do not need laws to tell them to act responsibly, while bad people will find a way around the laws. -- Plato --doUn1Hmx68n+7ij2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZCxfNQAKCRBhHseHBAsP q/S7AKCazTfhAcKqv8flP+R80WZytNxoXACglF4Eb3XbiU3yup7rhAN73Rtu5I8= =Bjfr -----END PGP SIGNATURE----- --doUn1Hmx68n+7ij2-- --===============0807913254473249618== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0807913254473249618==--