From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 88FBC45C95 for ; Sun, 2 Apr 2023 19:08:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 16EF668BEDE; Sun, 2 Apr 2023 22:08:28 +0300 (EEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 972F068BE41 for ; Sun, 2 Apr 2023 22:08:22 +0300 (EEST) Received: by mail-ed1-f42.google.com with SMTP id eh3so109107164edb.11 for ; Sun, 02 Apr 2023 12:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680462501; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=aHqXe02GOzNbCZP2Pwss6FYgT1nMMM5mPRcUXu6nVl4=; b=JXeyWmYWWGyul4ter+pFBwdG6HxDCDVYpvPdamlF6Sl4/rEcxeiM/w7rLJhSlDqinq UISQe2e0E0RocunItPtUZ7DeLAx1yugnQI3G9GiJx1b0+t2sFNTVIHkWrGCnGhTFebrk tp/yqd8d7fWmU5HMooO0DZgF5S4K+gjhBJ6Dt9Lvz+Eg60avu+8A4BFpxe24aE6NGdPa 4yJ4wrEEJIGIVprG1E+CAkDz2UbRlPKRr3B/vI3Nmuj8SuI34HgraS1o/tfprwy/+4Fb mUqq9xNwlYWJ55qzzHGLqJoP/4cpi4r7jz1tnbVS+4Pa7XsBWczA0fFsXKBikFju5nfW EgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680462501; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aHqXe02GOzNbCZP2Pwss6FYgT1nMMM5mPRcUXu6nVl4=; b=nDveBO4g5ejLZCws8dDMW7ETOet8MKcyCknSgliIp6hD2x10ZR4llua7E6+OzwxPFH Fj02EkJ4CrbYw7C9FG+8xXaYesbqx7kzXQPp1DNnXV3dr0TsrU/qLmhqAYmHNkncHlur b9KwsBj9e1X7dJoyXKHLfLPboAkt3QgAY6ykJ9sS7aXMsRuGvr2as9Efo47+I8Aknuyi 9IBqWQh1/CFr65Gn3bz4ugM52mLCRmF5Oq2EemXvGOwMkPBVGMzT/IxR24t7LqCq9tBi nHwkr4K3aCmPxmUb0s+WhwIfZxYL9ULtYn5c19cm4TP7zwmZhFKP8TDa8divdEnqqT7T gCqA== X-Gm-Message-State: AAQBX9dDTzn3FwT9p3A6nk+yrf+WIiyAR05Ztg5kj8vXW+1yXVehXnYp tWHSHAFt41V7u01jdZ42kfLRrtBrjfw= X-Google-Smtp-Source: AKy350aj3zIWtQ2sMp3nYmqBQ9JCgYc6Srm7BtoHfYx0H6PriIHlv/OeknvYL38x8K221bZB0p/1uA== X-Received: by 2002:aa7:d706:0:b0:4fb:c66f:71c4 with SMTP id t6-20020aa7d706000000b004fbc66f71c4mr14221051edq.11.1680462501384; Sun, 02 Apr 2023 12:08:21 -0700 (PDT) Received: from mariano (dynamic-adsl-62-10-98-143.clienti.tiscali.it. [62.10.98.143]) by smtp.gmail.com with ESMTPSA id m30-20020a50999e000000b005027d31615dsm3235835edb.62.2023.04.02.12.08.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 12:08:20 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id CC042BFB73; Sun, 2 Apr 2023 21:08:18 +0200 (CEST) Date: Sun, 2 Apr 2023 21:08:18 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230402190818.GK3542@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230330093809.22687-1-anton@khirnov.net> <20230330093809.22687-2-anton@khirnov.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230330093809.22687-2-anton@khirnov.net> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Thursday 2023-03-30 11:38:08 +0200, Anton Khirnov wrote: > Current log messages talk about 'suitable' output formats. This is > confusing, because it suggests that some formats are suitable, while > others are not, which is not the case. > > Also, suggest possible user actions when format cannot be guessed from a > filename. > --- > libavformat/mux.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index 0bc9b6b87d..415bd3948f 100644 > --- a/libavformat/mux.c > +++ b/libavformat/mux.c > @@ -102,7 +102,7 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat > if (format) { > oformat = av_guess_format(format, NULL, NULL); > if (!oformat) { > - av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not a suitable output format\n", format); > + av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not known.\n", format); > ret = AVERROR(EINVAL); > goto error; > } > @@ -110,8 +110,10 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat > oformat = av_guess_format(NULL, filename, NULL); > if (!oformat) { > ret = AVERROR(EINVAL); > - av_log(s, AV_LOG_ERROR, "Unable to find a suitable output format for '%s'\n", > - filename); > + av_log(s, AV_LOG_ERROR, > + "Unable to choose an output format for '%s'; " > + "use a standard extension for the filename or specify " > + "the format manually.\n", filename); LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".