Re: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name
Date: Sun, 2 Apr 2023 21:06:35 +0200
Message-ID: <20230402190635.GJ3542@mariano> (raw)
In-Reply-To: <20230330093809.22687-1-anton@khirnov.net>

On date Thursday 2023-03-30 11:38:07 +0200, Anton Khirnov wrote:
> An uninitialized AVFormatContext instance with neither iformat nor
> oformat set will currently log as 'NULL', which is confusing and
> unhelpful. Print 'AVFormatContext' instead, which provides more
> information.
> 
> This happens e.g. if choosing an output format fails in
> avformat_alloc_output_context2().
> ---
>  libavformat/options.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/options.c b/libavformat/options.c
> index 22ad523b2d..e4a3aceed0 100644
> --- a/libavformat/options.c
> +++ b/libavformat/options.c
> @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr)
>      AVFormatContext* fc = (AVFormatContext*) ptr;
>      if(fc->iformat) return fc->iformat->name;
>      else if(fc->oformat) return fc->oformat->name;
> -    else return "NULL";
> +    else return fc->av_class->class_name;
>  }

Do you have an example to show? Anyway LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".