From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C85945C8D for ; Sun, 2 Apr 2023 19:03:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 785F768BEAA; Sun, 2 Apr 2023 22:03:32 +0300 (EEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90EBE68BE98 for ; Sun, 2 Apr 2023 22:03:25 +0300 (EEST) Received: by mail-ed1-f54.google.com with SMTP id h8so109175307ede.8 for ; Sun, 02 Apr 2023 12:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680462204; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=ZIA5QHjdxAuaToAj01CH40jaEy/1wdJb47eHXC1Dw0Y=; b=KuobP4hfLxcWR5HKuBzoolMyyoOiSrXBYl4bUMnv+fLKSOkVb5YlDkXII+21hSfXaK 8MIMMaRPoy2TbiKf7WSJA9oNF8sWlGmKJvFHSkdW7DHyD+ZpmTCDtBOKFJPU0Jx4U/pX mocgeZ0MkyMlh95j2k+SrxF5D0d+Laz6bwHvaidHgFotnjwScNoJYfGdI/i9OH6+PSkG bWXw/v7Tl40vRKf4aMfEakoR2/WfyknsPC7lpcsOiizXAUDWDy68qNfG4rTcmgr3rtSY AOs6oVkZu1g99skyUM33mNlEb6Og0BnK3DsoFSvz5xbBVpZeJo7dW+Gii6f23NcOcxgn xAEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680462204; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZIA5QHjdxAuaToAj01CH40jaEy/1wdJb47eHXC1Dw0Y=; b=wDNSItV7PztT2ESEKDpU+mwQPNOsfks1R3GfbHUzGaYWA/f28QtO5nVXCqCxXKVi9X NhB/79N3I+cLBtGQMIAwrJiLr+K4wpQnfGwmQzzCOe0CHbhWlnzgEYMISOBz4+bBP4kW Ae8XxerpHBhpsmrbOw46YjswBEjZgU1MOjKhlI53Qjm1U9VE7A2kg/lfTJ73HX3YbVBq vsi/ehvJGBt6AnmxO6TMXPB+omeKyoYk9fIEyi8WtGFn+jKkFXcMRpFHhbzeoQL7aOyI e7XOhYHq4oGccAJVDaHeA0yrZg+EC/W6ikOr8gaWj4G/rumxkyMv1WwR28uCjc8NDNE9 eYkg== X-Gm-Message-State: AAQBX9ej036b7+qAg2i0hyUpP8x2uYvgwgNIX2zyddnvyjVo3ri7R7RF P+I6Kjg+nTosHIwG5ChH73ZWhnet3Lc= X-Google-Smtp-Source: AKy350bSmwPbDMqtcVWCnHyc52a/5d2YIHGYeB8RciFXp03wQglHnOs4U5Voqu0WHdNrtJ05JEuXFQ== X-Received: by 2002:a17:906:8398:b0:900:a150:cea3 with SMTP id p24-20020a170906839800b00900a150cea3mr33130256ejx.9.1680462203992; Sun, 02 Apr 2023 12:03:23 -0700 (PDT) Received: from mariano (dynamic-adsl-62-10-98-143.clienti.tiscali.it. [62.10.98.143]) by smtp.gmail.com with ESMTPSA id m23-20020a509317000000b004fbd365fb33sm3615446eda.38.2023.04.02.12.03.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 12:03:23 -0700 (PDT) Received: by mariano (Postfix, from userid 1000) id 4B365BFB73; Sun, 2 Apr 2023 21:03:21 +0200 (CEST) Date: Sun, 2 Apr 2023 21:03:21 +0200 From: Stefano Sabatini To: FFmpeg development discussions and patches Message-ID: <20230402190321.GI3542@mariano> Mail-Followup-To: FFmpeg development discussions and patches References: <20230402180535.43550-1-stefasab@gmail.com> <20230402181416.GH3542@mariano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230402181416.GH3542@mariano> User-Agent: Mutt/1.13.2 (2019-12-18) Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/avcodec.h: fix typos in AVCodecContext.pkt_timebase description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On date Sunday 2023-04-02 20:14:16 +0200, Stefano Sabatini wrote: > On date Sunday 2023-04-02 20:05:35 +0200, Stefano Sabatini wrote: > > --- > > libavcodec/avcodec.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > > index 1e91b9cb53..dec5e40eac 100644 > > --- a/libavcodec/avcodec.h > > +++ b/libavcodec/avcodec.h > > @@ -1781,9 +1781,9 @@ typedef struct AVCodecContext { > > enum AVPixelFormat sw_pix_fmt; > > > > /** > > - * Timebase in which pkt_dts/pts and AVPacket.dts/pts are. > > - * - encoding unused. > > - * - decoding set by user. > > + * Timebase in which pkt_dts/pts and AVPacket.dts/pts are expressed. > > + * - encoding: unused. > > + * - decoding: set by user. > > */ > > AVRational pkt_timebase; > > BTW, also I'm still confused by this field. > > What happens in case it is not set? In this case I assume the > decoder/libavcodec will pick a suitable timebase which is directly set > in the decoded frames? Is the field internally set in this case, or > the information is only stored in the output frames? > > How libavcodec detects if the field is set or not? Also, is there any guarantee that the decoded frame time base should be set based on the pkt_timebase value? In practice this does not happen (so that I had to set the time_base explicitly in the decoded frame in transcode.c). Is this expected or the library should explicitly set the time_base in the decoded frames? The latter is what I would expect. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".