* [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name @ 2023-03-30 9:38 Anton Khirnov 2023-03-30 9:38 ` [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails Anton Khirnov 2023-04-02 19:06 ` [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Stefano Sabatini 0 siblings, 2 replies; 5+ messages in thread From: Anton Khirnov @ 2023-03-30 9:38 UTC (permalink / raw) To: ffmpeg-devel An uninitialized AVFormatContext instance with neither iformat nor oformat set will currently log as 'NULL', which is confusing and unhelpful. Print 'AVFormatContext' instead, which provides more information. This happens e.g. if choosing an output format fails in avformat_alloc_output_context2(). --- libavformat/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/options.c b/libavformat/options.c index 22ad523b2d..e4a3aceed0 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr) AVFormatContext* fc = (AVFormatContext*) ptr; if(fc->iformat) return fc->iformat->name; else if(fc->oformat) return fc->oformat->name; - else return "NULL"; + else return fc->av_class->class_name; } static void *format_child_next(void *obj, void *prev) -- 2.39.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails 2023-03-30 9:38 [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Anton Khirnov @ 2023-03-30 9:38 ` Anton Khirnov 2023-04-02 19:08 ` Stefano Sabatini 2023-04-02 19:06 ` [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Stefano Sabatini 1 sibling, 1 reply; 5+ messages in thread From: Anton Khirnov @ 2023-03-30 9:38 UTC (permalink / raw) To: ffmpeg-devel Current log messages talk about 'suitable' output formats. This is confusing, because it suggests that some formats are suitable, while others are not, which is not the case. Also, suggest possible user actions when format cannot be guessed from a filename. --- libavformat/mux.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 0bc9b6b87d..415bd3948f 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -102,7 +102,7 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat if (format) { oformat = av_guess_format(format, NULL, NULL); if (!oformat) { - av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not a suitable output format\n", format); + av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not known.\n", format); ret = AVERROR(EINVAL); goto error; } @@ -110,8 +110,10 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat oformat = av_guess_format(NULL, filename, NULL); if (!oformat) { ret = AVERROR(EINVAL); - av_log(s, AV_LOG_ERROR, "Unable to find a suitable output format for '%s'\n", - filename); + av_log(s, AV_LOG_ERROR, + "Unable to choose an output format for '%s'; " + "use a standard extension for the filename or specify " + "the format manually.\n", filename); goto error; } } -- 2.39.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails 2023-03-30 9:38 ` [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails Anton Khirnov @ 2023-04-02 19:08 ` Stefano Sabatini 0 siblings, 0 replies; 5+ messages in thread From: Stefano Sabatini @ 2023-04-02 19:08 UTC (permalink / raw) To: FFmpeg development discussions and patches On date Thursday 2023-03-30 11:38:08 +0200, Anton Khirnov wrote: > Current log messages talk about 'suitable' output formats. This is > confusing, because it suggests that some formats are suitable, while > others are not, which is not the case. > > Also, suggest possible user actions when format cannot be guessed from a > filename. > --- > libavformat/mux.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index 0bc9b6b87d..415bd3948f 100644 > --- a/libavformat/mux.c > +++ b/libavformat/mux.c > @@ -102,7 +102,7 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat > if (format) { > oformat = av_guess_format(format, NULL, NULL); > if (!oformat) { > - av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not a suitable output format\n", format); > + av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not known.\n", format); > ret = AVERROR(EINVAL); > goto error; > } > @@ -110,8 +110,10 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat > oformat = av_guess_format(NULL, filename, NULL); > if (!oformat) { > ret = AVERROR(EINVAL); > - av_log(s, AV_LOG_ERROR, "Unable to find a suitable output format for '%s'\n", > - filename); > + av_log(s, AV_LOG_ERROR, > + "Unable to choose an output format for '%s'; " > + "use a standard extension for the filename or specify " > + "the format manually.\n", filename); LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name 2023-03-30 9:38 [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Anton Khirnov 2023-03-30 9:38 ` [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails Anton Khirnov @ 2023-04-02 19:06 ` Stefano Sabatini 2023-04-03 10:16 ` Anton Khirnov 1 sibling, 1 reply; 5+ messages in thread From: Stefano Sabatini @ 2023-04-02 19:06 UTC (permalink / raw) To: FFmpeg development discussions and patches On date Thursday 2023-03-30 11:38:07 +0200, Anton Khirnov wrote: > An uninitialized AVFormatContext instance with neither iformat nor > oformat set will currently log as 'NULL', which is confusing and > unhelpful. Print 'AVFormatContext' instead, which provides more > information. > > This happens e.g. if choosing an output format fails in > avformat_alloc_output_context2(). > --- > libavformat/options.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/options.c b/libavformat/options.c > index 22ad523b2d..e4a3aceed0 100644 > --- a/libavformat/options.c > +++ b/libavformat/options.c > @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr) > AVFormatContext* fc = (AVFormatContext*) ptr; > if(fc->iformat) return fc->iformat->name; > else if(fc->oformat) return fc->oformat->name; > - else return "NULL"; > + else return fc->av_class->class_name; > } Do you have an example to show? Anyway LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name 2023-04-02 19:06 ` [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Stefano Sabatini @ 2023-04-03 10:16 ` Anton Khirnov 0 siblings, 0 replies; 5+ messages in thread From: Anton Khirnov @ 2023-04-03 10:16 UTC (permalink / raw) To: FFmpeg development discussions and patches Quoting Stefano Sabatini (2023-04-02 21:06:35) > On date Thursday 2023-03-30 11:38:07 +0200, Anton Khirnov wrote: > > An uninitialized AVFormatContext instance with neither iformat nor > > oformat set will currently log as 'NULL', which is confusing and > > unhelpful. Print 'AVFormatContext' instead, which provides more > > information. > > > > This happens e.g. if choosing an output format fails in > > avformat_alloc_output_context2(). > > --- > > libavformat/options.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/options.c b/libavformat/options.c > > index 22ad523b2d..e4a3aceed0 100644 > > --- a/libavformat/options.c > > +++ b/libavformat/options.c > > @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr) > > AVFormatContext* fc = (AVFormatContext*) ptr; > > if(fc->iformat) return fc->iformat->name; > > else if(fc->oformat) return fc->oformat->name; > > - else return "NULL"; > > + else return fc->av_class->class_name; > > } > > Do you have an example to show? Anyway LGTM. ./ffmpeg -i /tmp/s.mkv -f foobar -y /dev/null before: [NULL @ 0x5580377834c0] Requested output format 'foobar' is not a suitable output format after: [AVFormatContext @ 0x55fa15bb34c0] Requested output format 'foobar' is not a suitable output format -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-03 10:16 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-03-30 9:38 [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Anton Khirnov 2023-03-30 9:38 ` [FFmpeg-devel] [PATCH 2/2] lavf/mux: clarify log messages when choosing oformat fails Anton Khirnov 2023-04-02 19:08 ` Stefano Sabatini 2023-04-02 19:06 ` [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name Stefano Sabatini 2023-04-03 10:16 ` Anton Khirnov
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git