From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C4374539F for ; Wed, 29 Mar 2023 18:09:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3446E68C3D7; Wed, 29 Mar 2023 21:09:00 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D16F168C38F for ; Wed, 29 Mar 2023 21:08:53 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 190E0240006 for ; Wed, 29 Mar 2023 18:08:52 +0000 (UTC) Date: Wed, 29 Mar 2023 20:08:51 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230329180851.GB1164690@pb2> References: <20230325191529.10578-1-anton@khirnov.net> <20230325191529.10578-8-anton@khirnov.net> <20230325214349.GA375355@pb2> MIME-Version: 1.0 In-Reply-To: <20230325214349.GA375355@pb2> Subject: Re: [FFmpeg-devel] [PATCH 08/23] fftools/ffmpeg: use sync queues for enforcing audio frame size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8097063953264792002==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8097063953264792002== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ" Content-Disposition: inline --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 25, 2023 at 10:43:49PM +0100, Michael Niedermayer wrote: > On Sat, Mar 25, 2023 at 08:15:14PM +0100, Anton Khirnov wrote: > > The code currently uses lavfi for this, which creates a sort of > > configuration dependency loop - the encoder should be ideally > > initialized with information from the first audio frame, but to get this > > frame one needs to first open the encoder to know the frame size. This > > necessitates an awkward workaround, which causes audio handling to be > > different from video. > >=20 > > With this change, audio encoder initialization is congruent with video. > > --- > > fftools/ffmpeg.c | 58 ++++++++------------------------------- > > fftools/ffmpeg_filter.c | 8 ------ > > fftools/ffmpeg_mux_init.c | 19 +++++++++---- > > 3 files changed, 25 insertions(+), 60 deletions(-) >=20 > this results in the following to be apparently stuck >=20 > ffmpeg -y -i https://samples.ffmpeg.org/V-codecs/geov.avi -t 1 file.avi This patch causes more issues it seems the following: =2E/ffmpeg -i AnivisionLogo.bik -t 1 -y test.avi see https://samples.ffmpeg.org/game-formats/bink/ produces: =3D=3D9868=3D=3D Process terminating with default action of signal 11 (SIGS= EGV) =3D=3D9868=3D=3D General Protection Fault =3D=3D9868=3D=3D at 0x11D3CAD: ??? (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x9ACA31: mp3lame_encode_frame (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x882EC4: ff_encode_encode_cb (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x8832DD: encode_receive_packet_internal (in ffmpeg/= ffmpeg_g) =3D=3D9868=3D=3D by 0x8834BF: avcodec_send_frame (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x31A281: encode_frame (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x31F901: transcode (in ffmpeg/ffmpeg_g) =3D=3D9868=3D=3D by 0x2F0843: main (in ffmpeg/ffmpeg_g) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream we wish for rather than the science we have, -- Dr. Kenneth Brown --8P1HSweYDcXXzwPJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZCR+swAKCRBhHseHBAsP q4cdAJ96g2pfSa+QwYOMfcBO3ia3HxJciwCeI2UkXJTncuqOaRxE+xWfnInE78U= =B6/V -----END PGP SIGNATURE----- --8P1HSweYDcXXzwPJ-- --===============8097063953264792002== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8097063953264792002==--