From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/frobe: print crop_* frame fields
Date: Sun, 26 Mar 2023 21:36:34 +0200
Message-ID: <20230326193634.GG26811@mariano> (raw)
In-Reply-To: <20230326193040.56263-1-jamrial@gmail.com>
Nit: "fprobe" typo
On date Sunday 2023-03-26 16:30:40 -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> doc/ffprobe.xsd | 4 +
> fftools/ffprobe.c | 4 +
> tests/ref/fate/exif-image-embedded | 4 +
> tests/ref/fate/exif-image-jpg | 4 +
> tests/ref/fate/exif-image-tiff | 4 +
> tests/ref/fate/exif-image-webp | 4 +
> tests/ref/fate/ffprobe_compact | 16 ++--
> tests/ref/fate/ffprobe_csv | 16 ++--
> tests/ref/fate/ffprobe_default | 32 +++++++
> tests/ref/fate/ffprobe_flat | 32 +++++++
> tests/ref/fate/ffprobe_ini | 32 +++++++
> tests/ref/fate/ffprobe_json | 32 +++++++
> tests/ref/fate/ffprobe_xml | 16 ++--
> tests/ref/fate/ffprobe_xsd | 16 ++--
> tests/ref/fate/h264-dts_5frames | 20 +++++
> tests/ref/fate/jpg-icc | 4 +
> tests/ref/fate/mov-zombie | 130 ++++++++++++++---------------
> tests/ref/fate/png-icc | 4 +
> tests/ref/fate/png-side-data | 4 +
> 19 files changed, 281 insertions(+), 97 deletions(-)
>
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index 0920380108..87ca265d63 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
> @@ -106,6 +106,10 @@
> <!-- video attributes -->
> <xsd:attribute name="width" type="xsd:long" />
> <xsd:attribute name="height" type="xsd:long" />
> + <xsd:attribute name="crop_top" type="xsd:long" />
> + <xsd:attribute name="crop_bottom" type="xsd:long" />
> + <xsd:attribute name="crop_left" type="xsd:long" />
> + <xsd:attribute name="crop_right" type="xsd:long" />
> <xsd:attribute name="pix_fmt" type="xsd:string"/>
> <xsd:attribute name="sample_aspect_ratio" type="xsd:string"/>
> <xsd:attribute name="pict_type" type="xsd:string"/>
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 561b514f0b..d6e5a79c7e 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2620,6 +2620,10 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> case AVMEDIA_TYPE_VIDEO:
> print_int("width", frame->width);
> print_int("height", frame->height);
> + print_int("crop_top", frame->crop_top);
> + print_int("crop_bottom", frame->crop_bottom);
> + print_int("crop_left", frame->crop_left);
> + print_int("crop_right", frame->crop_left);
LGTM, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-26 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 19:30 James Almer
2023-03-26 19:36 ` Stefano Sabatini [this message]
2023-03-26 19:41 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326193634.GG26811@mariano \
--to=stefasab@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git