Re: [FFmpeg-devel] [PATCH] ffmpeg: make timestamp discontinuity logging a warning

From: Stefano Sabatini <stefasab@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: make timestamp discontinuity logging a warning
Date: Sat, 25 Mar 2023 16:43:35 +0100
Message-ID: <20230325154335.GD26811@mariano> (raw)
In-Reply-To: <20230324141927.69095-1-jeebjp@gmail.com>

On date Friday 2023-03-24 16:19:27 +0200, Jan Ekström wrote:
> From: Nongji Chen <nchen@aminocom.com>
> 
> In most cases this should only occur once or so per stream in an
> input, and in case the logic ends up in an eternal loop, it should
> be visible to the end user instead of being completely invisible.
> 
> Signed-off-by: Jan Ekström <jan.ekstrom@24i.com>
> ---
>  fftools/ffmpeg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 438bee8fef..1428988f9d 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -3696,7 +3696,7 @@ static void ts_discontinuity_detect(InputFile *ifile, InputStream *ist,
>              if (FFABS(delta) > 1LL * dts_delta_threshold * AV_TIME_BASE ||
>                  pkt_dts + AV_TIME_BASE/10 < FFMAX(ist->pts, ist->dts)) {
>                  ifile->ts_offset_discont -= delta;
> -                av_log(NULL, AV_LOG_DEBUG,
> +                av_log(NULL, AV_LOG_WARNING,
>                         "timestamp discontinuity for stream #%d:%d "
>                         "(id=%d, type=%s): %"PRId64", new offset= %"PRId64"\n",
>                         ist->file_index, ist->st->index, ist->st->id,

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".