From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DDD214066E for ; Sat, 25 Mar 2023 11:39:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CC38868C691; Sat, 25 Mar 2023 13:39:29 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1190B68C575 for ; Sat, 25 Mar 2023 13:39:23 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id DC4D24000B for ; Sat, 25 Mar 2023 11:39:22 +0000 (UTC) Date: Sat, 25 Mar 2023 12:39:22 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230325113922.GS375355@pb2> References: <20230324155213.3493-1-jamrial@gmail.com> <20230324155213.3493-5-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230324155213.3493-5-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0552114158541322209==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0552114158541322209== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2/Dpz40iF3jpiHxF" Content-Disposition: inline --2/Dpz40iF3jpiHxF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 24, 2023 at 12:52:11PM -0300, James Almer wrote: > A non zero value is mandatory for Matroska if the track has blocks with B= lockAdditions. >=20 > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 39 +++++++++++++++++-- > tests/ref/fate/aac-autobsf-adtstoasc | 4 +- > tests/ref/fate/matroska-avoid-negative-ts | 4 +- > tests/ref/fate/matroska-dovi-write-config7 | 4 +- > tests/ref/fate/matroska-dovi-write-config8 | 4 +- > tests/ref/fate/matroska-dvbsub-remux | 4 +- > tests/ref/fate/matroska-encoding-delay | 14 +++---- > tests/ref/fate/matroska-flac-extradata-update | 4 +- > tests/ref/fate/matroska-h264-remux | 4 +- > .../fate/matroska-mastering-display-metadata | 4 +- > tests/ref/fate/matroska-move-cues-to-front | 4 +- > tests/ref/fate/matroska-mpegts-remux | 4 +- > tests/ref/fate/matroska-ms-mode | 4 +- > tests/ref/fate/matroska-ogg-opus-remux | 10 ++--- > tests/ref/fate/matroska-opus-remux | 10 ++--- > tests/ref/fate/matroska-pgs-remux | 4 +- > tests/ref/fate/matroska-pgs-remux-durations | 4 +- > tests/ref/fate/matroska-qt-mode | 4 +- > tests/ref/fate/matroska-spherical-mono-remux | 4 +- > tests/ref/fate/matroska-vp8-alpha-remux | 4 +- > tests/ref/fate/matroska-zero-length-block | 4 +- > tests/ref/fate/rgb24-mkv | 4 +- > tests/ref/fate/shortest-sub | 4 +- > tests/ref/lavf-fate/av1.mkv | 4 +- > tests/ref/lavf/mka | 4 +- > tests/ref/lavf/mkv | 4 +- > tests/ref/lavf/mkv_attachment | 4 +- > 27 files changed, 98 insertions(+), 67 deletions(-) breaks fate-seek-lavf-mkv --- ./tests/ref/seek/lavf-mkv 2023-03-23 18:35:14.674286905 +0100 +++ tests/data/fate/seek-lavf-mkv 2023-03-25 12:34:27.968618366 +0100 @@ -1,48 +1,48 @@ -ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 657 size:= 208 +ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 665 size:= 208 ret: 0 st:-1 flags:0 ts:-1.000000 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret: 0 st:-1 flags:1 ts: 1.894167 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret: 0 st: 0 flags:0 ts: 0.788000 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret: 0 st: 0 flags:1 ts:-0.317000 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret:-1 st: 1 flags:0 ts: 2.577000 ret: 0 st: 1 flags:1 ts: 1.471000 -ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320130 size:= 209 +ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320138 size:= 209 ret: 0 st:-1 flags:0 ts: 0.365002 -ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146841 size:= 27925 +ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146849 size:= 27925 ret: 0 st:-1 flags:1 ts:-0.740831 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret:-1 st: 0 flags:0 ts: 2.153000 ret: 0 st: 0 flags:1 ts: 1.048000 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret: 0 st: 1 flags:0 ts:-0.058000 -ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 657 size:= 208 +ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 665 size:= 208 ret: 0 st: 1 flags:1 ts: 2.836000 -ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320130 size:= 209 +ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320138 size:= 209 ret:-1 st:-1 flags:0 ts: 1.730004 ret: 0 st:-1 flags:1 ts: 0.624171 -ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146841 size:= 27925 +ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146849 size:= 27925 ret: 0 st: 0 flags:0 ts:-0.482000 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret: 0 st: 0 flags:1 ts: 2.413000 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret:-1 st: 1 flags:0 ts: 1.307000 ret: 0 st: 1 flags:1 ts: 0.201000 -ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 657 size:= 208 +ret: 0 st: 1 flags:1 dts:-0.011000 pts:-0.011000 pos: 665 size:= 208 ret: 0 st:-1 flags:0 ts:-0.904994 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret: 0 st:-1 flags:1 ts: 1.989173 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret: 0 st: 0 flags:0 ts: 0.883000 -ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292289 size:= 27834 +ret: 0 st: 0 flags:1 dts: 0.960000 pts: 0.960000 pos: 292297 size:= 27834 ret: 0 st: 0 flags:1 ts:-0.222000 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 ret:-1 st: 1 flags:0 ts: 2.672000 ret: 0 st: 1 flags:1 ts: 1.566000 -ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320130 size:= 209 +ret: 0 st: 1 flags:1 dts: 0.982000 pts: 0.982000 pos: 320138 size:= 209 ret: 0 st:-1 flags:0 ts: 0.460008 -ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146841 size:= 27925 +ret: 0 st: 0 flags:1 dts: 0.480000 pts: 0.480000 pos: 146849 size:= 27925 ret: 0 st:-1 flags:1 ts:-0.645825 -ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 873 size:= 27837 +ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: 881 size:= 27837 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data --2/Dpz40iF3jpiHxF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZB7dZAAKCRBhHseHBAsP q7pUAJ0chDUu2Xg+fS6pawzUaR/F3zv6RQCfVgjTfTc1J5iKl9V/oRagJKuteIM= =1lHe -----END PGP SIGNATURE----- --2/Dpz40iF3jpiHxF-- --===============0552114158541322209== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0552114158541322209==--