From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 145D245BC9 for ; Sat, 25 Mar 2023 00:37:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BA2A68C932; Sat, 25 Mar 2023 02:37:25 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DF6CA68C8CB for ; Sat, 25 Mar 2023 02:37:19 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 0A644100002 for ; Sat, 25 Mar 2023 00:37:18 +0000 (UTC) Date: Sat, 25 Mar 2023 01:37:18 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230325003718.GR375355@pb2> References: <20230321123729.74124-1-martin@martin.st> MIME-Version: 1.0 In-Reply-To: <20230321123729.74124-1-martin@martin.st> Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavformat: Improve ff_configure_buffers_for_index for excessive deltas X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2877808125587504930==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2877808125587504930== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OrT4iOlIQZp3kw4S" Content-Disposition: inline --OrT4iOlIQZp3kw4S Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 21, 2023 at 02:37:28PM +0200, Martin Storsj=F6 wrote: > Previously, the ff_configure_buffers_for_index function had > upper sanity limits of 16 MB (1<<24) for buffer_size and > 8 MB (1<<23) for short_seek_threshold. >=20 > However, if the index analysis showed a need for even larger > buffer sizes (for a really badly interleaved file), over the > sanity limits, we previously didn't increase the buffer sizes > at all. >=20 > Instead, if the file shows a need for really large buffers and > short_seek_threshold, just set them to the maximum sanity limit; > while it might not be enough for all cases in the file, it might > be enough for most of it. >=20 > This can happen e.g. with a mov file with some tracks containing > some samples that belong in the start of the file, at the end of > the mdat, while the rest of the file is mostly reasonably interleaved; > previously those samples caused the maximum pos_delta to skyrocket, > skipping any buffer size enlargement. >=20 > Signed-off-by: Martin Storsj=F6 > --- > libavformat/seek.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) I think, if iam not too tired ATM that instead of taking the maximum it would be better to ignore the cases which are above the maximum, so the value would be optimal for the cases that it can help [...] thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is a danger to trust the dream we wish for rather than the science we have, -- Dr. Kenneth Brown --OrT4iOlIQZp3kw4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZB5CNwAKCRBhHseHBAsP q6tVAJ4suDtnfT3g3r47M+QeKXE89k7DSwCdHSXXo2WJE0ygoszBu5Mb2hzsO7Q= =WX7P -----END PGP SIGNATURE----- --OrT4iOlIQZp3kw4S-- --===============2877808125587504930== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2877808125587504930==--