From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 51B4F45BC9 for ; Fri, 24 Mar 2023 22:21:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A15D468C8F4; Sat, 25 Mar 2023 00:21:14 +0200 (EET) Received: from mail.overt.org (mail.overt.org [72.14.183.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E7B0368BF62 for ; Sat, 25 Mar 2023 00:21:08 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=overt.org; s=mail; t=1679696467; bh=hQwSuKMWuaXI2dbfb+QtiYb3aWES3t1aQPec9FZVoj4=; h=From:To:Cc:Subject:Date:From; b=IS50xG/cfkyAaa1v81M1OelxCSDNpVnyVGnTZsbBKa965qqbUvJQK+fPq6RvPcTYj CsRDovNc6H2tHmYxfRDO+PJJGpltGS4OaNAia9jVM0tAr4qyk29u9pvr+XvgoCMRFv LFTzeTWXobFV3C6tZ4lYrD0nIw+u0bXByv2xDuXhJ14GCswH2sZTmIxQHHXOwIT01K IRSes2xta1Rzg7j4NnDxdkIrduUdXnn7QK/0fGHj7+A+9V2BDjGeGgQNhqWatBGdcm K/6CXAkNEtKpLylgv8uaZZ1/oYij6UKf8uzlSvIsPDhWzztlu9RULQAiGvsoJIb2CU 3q+Fi6/wbNsNw== Received: from authenticated-user (mail.overt.org [72.14.183.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.overt.org (Postfix) with ESMTPSA id 14CC160844; Fri, 24 Mar 2023 17:21:07 -0500 (CDT) From: Philip Langdale To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 Mar 2023 15:20:58 -0700 Message-Id: <20230324222058.148659-1-philipl@overt.org> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif: Remove undesireable spatial preference logic X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thomas Mundt , Philip Langdale Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: bwdif inherited this check from yadif, which was originally supposed to prefer the spatial predictor if the temporal predictor was too far off. However, the core bwdif algorithm already accounts for the spatial predictor, so this additional check actually ends up preferring a worse value, reducing the overall quality. This was found by cyanreg while writing bwdif_vulkan, and the visual improvement is pretty dramatic in some samples. If we agree that this change is desirable, we should update all implementations. Signed-off-by: Philip Langdale --- libavfilter/vf_bwdif.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavfilter/vf_bwdif.c b/libavfilter/vf_bwdif.c index 65c617ebb3..441bb11e7b 100644 --- a/libavfilter/vf_bwdif.c +++ b/libavfilter/vf_bwdif.c @@ -106,11 +106,6 @@ typedef struct ThreadData { interpol = (c + e) >> 1; #define FILTER2() \ - if (interpol > d + diff) \ - interpol = d + diff; \ - else if (interpol < d - diff) \ - interpol = d - diff; \ - \ dst[0] = av_clip(interpol, 0, clip_max); \ } \ \ -- 2.37.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".