From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B64B9457AA for ; Fri, 24 Mar 2023 09:31:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1247C68C715; Fri, 24 Mar 2023 11:31:01 +0200 (EET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 821CE68C0BA for ; Fri, 24 Mar 2023 11:30:54 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id CB9BE4000A for ; Fri, 24 Mar 2023 09:30:53 +0000 (UTC) Date: Fri, 24 Mar 2023 10:30:52 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20230324093052.GP375355@pb2> References: <20230324002540.3227-1-michael@niedermayer.cc> <20230324002540.3227-2-michael@niedermayer.cc> <167964783795.27013.16464276337894246810@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <167964783795.27013.16464276337894246810@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 2/6] tools/enc_recon_frame_test: plane 0 height fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8926712328413897475==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8926712328413897475== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0UhZIN3Sa23/ILEd" Content-Disposition: inline --0UhZIN3Sa23/ILEd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 24, 2023 at 09:50:37AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-03-24 01:25:36) > > Signed-off-by: Michael Niedermayer > > --- > > tools/enc_recon_frame_test.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c > > index 8f09ded47e..1ea2293ee7 100644 > > --- a/tools/enc_recon_frame_test.c > > +++ b/tools/enc_recon_frame_test.c > > @@ -83,7 +83,7 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_= c, int64_t ts, > > int linesize =3D av_image_get_linesize(frame->format, frame->w= idth, p); > > uint32_t checksum =3D 0; > > =20 > > - for (int j =3D 0; j < frame->height >> shift_v; j++) { > > + for (int j =3D 0; j < frame->height >> (shift_v *!!p); j++) { >=20 > IIUC this won't work for alpha. Might as well make it completely > generic. yes, i didnt really think much about this, it was more a issue i ran into and wanted to report. After all the tool isnt in git master yet=20 >=20 > I'll send an updated version of the tool, thank you for reminding me. [...] thx --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --0UhZIN3Sa23/ILEd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZB1txAAKCRBhHseHBAsP q2QjAJ9FWZXip4vof3w878JBmX1lDd6wpACgioGlcsmuubTBGKq9ueugSDbpovE= =2gUv -----END PGP SIGNATURE----- --0UhZIN3Sa23/ILEd-- --===============8926712328413897475== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8926712328413897475==--