Re: [FFmpeg-devel] [PATCH 2/6] tools/enc_recon_frame_test: plane 0 height fix

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1383 bytes --]

On Fri, Mar 24, 2023 at 09:50:37AM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2023-03-24 01:25:36)
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  tools/enc_recon_frame_test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c
> > index 8f09ded47e..1ea2293ee7 100644
> > --- a/tools/enc_recon_frame_test.c
> > +++ b/tools/enc_recon_frame_test.c
> > @@ -83,7 +83,7 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_c, int64_t ts,
> >          int linesize = av_image_get_linesize(frame->format, frame->width, p);
> >          uint32_t checksum = 0;
> >  
> > -        for (int j = 0; j < frame->height >> shift_v; j++) {
> > +        for (int j = 0; j < frame->height >> (shift_v *!!p); j++) {
> 
> IIUC this won't work for alpha. Might as well make it completely
> generic.

yes, i didnt really think much about this, it was more a issue i ran into
and wanted to report. After all the tool isnt in git master yet 

> 
> I'll send an updated version of the tool, thank you for reminding me.

[...]

thx
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".