Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 4/7] avformat/matroska: add a few more Block Addition ID Type enum values
Date: Tue, 21 Mar 2023 14:06:34 -0300
Message-ID: <20230321170637.10907-4-jamrial@gmail.com> (raw)
In-Reply-To: <20230321170637.10907-1-jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/matroska.h    | 3 +++
 libavformat/matroskadec.c | 4 ++--
 libavformat/matroskaenc.c | 4 ++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/libavformat/matroska.h b/libavformat/matroska.h
index 8a9c1b5119..04719f1d06 100644
--- a/libavformat/matroska.h
+++ b/libavformat/matroska.h
@@ -360,7 +360,10 @@ typedef enum {
 
 typedef enum {
   MATROSKA_BLOCK_ADD_ID_TYPE_DEFAULT                     = 0,
+  MATROSKA_BLOCK_ADD_ID_TYPE_OPAQUE_DATA                 = 1,
   MATROSKA_BLOCK_ADD_ID_TYPE_ITU_T_T35                   = 4,
+  MATROSKA_BLOCK_ADD_ID_TYPE_DVCC                        = 0x64766343,
+  MATROSKA_BLOCK_ADD_ID_TYPE_DVVC                        = 0x64767643,
 } MatroskaBlockAddIDType;
 
 /*
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index b1d2391840..68f9271e73 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -2404,8 +2404,8 @@ static int mkv_parse_block_addition_mappings(AVFormatContext *s, AVStream *st, M
             }
             track->blockaddid_itu_t_t35 = 1;
             break;
-        case MKBETAG('d','v','c','C'):
-        case MKBETAG('d','v','v','C'):
+        case MATROSKA_BLOCK_ADD_ID_TYPE_DVCC:
+        case MATROSKA_BLOCK_ADD_ID_TYPE_DVVC:
             if ((ret = mkv_parse_dvcc_dvvc(s, st, track, &mapping->extradata)) < 0)
                 return ret;
 
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 954b7d828f..46f4331a18 100644
--- a/libavformat/matroskaenc.c
+++ b/libavformat/matroskaenc.c
@@ -1612,9 +1612,9 @@ static void mkv_write_dovi(AVFormatContext *s, AVIOContext *pb, AVStream *st)
                                 + (2 + 1 + 4) + (2 + 1 + ISOM_DVCC_DVVC_SIZE);
 
         if (dovi->dv_profile > 7) {
-            type = MKBETAG('d', 'v', 'v', 'C');
+            type = MATROSKA_BLOCK_ADD_ID_TYPE_DVVC;
         } else {
-            type = MKBETAG('d', 'v', 'c', 'C');
+            type = MATROSKA_BLOCK_ADD_ID_TYPE_DVCC;
         }
 
         ff_isom_put_dvcc_dvvc(s, buf, dovi);
-- 
2.40.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-03-21 17:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 17:06 [FFmpeg-devel] [PATCH 1/7] avformat/matroskadec: support parsing more than one BlockMore element James Almer
2023-03-21 17:06 ` [FFmpeg-devel] [PATCH 2/7] avformat/matroskadec: set the default value for BlockAddIDType James Almer
2023-03-21 17:06 ` [FFmpeg-devel] [PATCH 3/7] avformat/matroskadec: export Dynamic HDR10+ packet side data James Almer
2023-03-24 11:18   ` Anton Khirnov
2023-03-24 11:28     ` James Almer
2023-03-24 11:40       ` Anton Khirnov
2023-03-24 12:34         ` James Almer
2023-03-21 17:06 ` James Almer [this message]
2023-03-21 17:06 ` [FFmpeg-devel] [PATCH 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element James Almer
2023-03-21 17:59   ` [FFmpeg-devel] [PATCH v2 " James Almer
2023-03-24 11:37   ` [FFmpeg-devel] [PATCH " Anton Khirnov
2023-03-24 11:41     ` James Almer
2023-03-24 11:43       ` Anton Khirnov
2023-03-21 17:06 ` [FFmpeg-devel] [PATCH 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data James Almer
2023-03-21 18:00   ` [FFmpeg-devel] [PATCH v2 " James Almer
2023-03-24 11:45     ` Anton Khirnov
2023-03-24 11:50       ` James Almer
2023-03-24 11:58         ` Anton Khirnov
2023-03-24 12:59           ` James Almer
2023-03-24 15:11             ` Jerome Martinez
2023-03-24 15:39               ` James Almer
2023-03-21 17:06 ` [FFmpeg-devel] [PATCH 7/7] fate/matroska: add HDR10+ muxing tests James Almer
2023-03-21 18:00   ` [FFmpeg-devel] [PATCH v2 " James Almer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321170637.10907-4-jamrial@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git