From: "Jan Ekström" <jeebjp@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v0 04/14] avutil/frame: split side data list wiping out to non-AVFrame function
Date: Tue, 21 Mar 2023 01:33:58 +0200
Message-ID: <20230320233408.134255-5-jeebjp@gmail.com> (raw)
In-Reply-To: <20230320233408.134255-1-jeebjp@gmail.com>
---
libavutil/frame.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index c905e8d611..019613e4d2 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -76,14 +76,18 @@ static void free_side_data(AVFrameSideData **ptr_sd)
av_freep(ptr_sd);
}
-static void wipe_side_data(AVFrame *frame)
+static void wipe_side_data(AVFrameSideData ***sd, int *nb_side_data)
{
- for (int i = 0; i < frame->nb_side_data; i++) {
- free_side_data(&frame->side_data[i]);
+ for (int i = 0; i < *nb_side_data; i++) {
+ free_side_data(&((*sd)[i]));
}
- frame->nb_side_data = 0;
+ *nb_side_data = 0;
+
+ av_freep(sd);
+}
- av_freep(&frame->side_data);
+static void wipe_side_data_from_frame(AVFrame *frame) {
+ wipe_side_data(&frame->side_data, &frame->nb_side_data);
}
AVFrame *av_frame_alloc(void)
@@ -326,7 +330,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
sd_dst = av_frame_new_side_data(dst, sd_src->type,
sd_src->size);
if (!sd_dst) {
- wipe_side_data(dst);
+ wipe_side_data_from_frame(dst);
return AVERROR(ENOMEM);
}
memcpy(sd_dst->data, sd_src->data, sd_src->size);
@@ -335,7 +339,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
sd_dst = av_frame_new_side_data_from_buf(dst, sd_src->type, ref);
if (!sd_dst) {
av_buffer_unref(&ref);
- wipe_side_data(dst);
+ wipe_side_data_from_frame(dst);
return AVERROR(ENOMEM);
}
}
@@ -486,7 +490,7 @@ void av_frame_unref(AVFrame *frame)
if (!frame)
return;
- wipe_side_data(frame);
+ wipe_side_data_from_frame(frame);
for (int i = 0; i < FF_ARRAY_ELEMS(frame->buf); i++)
av_buffer_unref(&frame->buf[i]);
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-20 23:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 23:33 [FFmpeg-devel] [PATCH v0 00/14] encoder AVCodecContext configuration side data Jan Ekström
2023-03-20 23:33 ` [FFmpeg-devel] [PATCH v0 01/14] avutil/frame: move counters utilized in loops to their scope Jan Ekström
2023-03-24 10:33 ` Anton Khirnov
2023-03-24 12:00 ` Jan Ekström
2023-03-20 23:33 ` [FFmpeg-devel] [PATCH v0 02/14] avcodec: move AVCodecInternal allocation to avcodec_alloc_context3 Jan Ekström
2023-03-24 10:41 ` Anton Khirnov
2023-03-24 12:07 ` Andreas Rheinhardt
2023-03-24 13:02 ` James Almer
2023-03-24 13:20 ` Anton Khirnov
2023-03-24 17:23 ` Michael Niedermayer
2023-03-24 17:26 ` Andreas Rheinhardt
2023-03-20 23:33 ` [FFmpeg-devel] [PATCH v0 03/14] avutil/frame: add AVFrameSideDataSet for passing sets of side data Jan Ekström
2023-03-20 23:33 ` Jan Ekström [this message]
2023-03-20 23:33 ` [FFmpeg-devel] [PATCH v0 05/14] avutil/frame: add helper for clearing out side data sets Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 06/14] avutil/frame: split side_data_from_buf to base and AVFrame func Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 07/14] avutil/frame: add helper for adding side data to set Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 08/14] avutil/frame: add helper for getting side data from set Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 09/14] avcodec: add private side data set to AVCodecInternal Jan Ekström
2023-03-24 10:50 ` Anton Khirnov
2023-03-24 17:34 ` Jan Ekström
2023-03-26 19:00 ` Anton Khirnov
2023-03-26 19:03 ` James Almer
2023-03-27 6:40 ` Jan Ekström
2023-03-27 6:37 ` Jan Ekström
2023-03-27 7:08 ` Anton Khirnov
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 10/14] avcodec: add function for setting avctx side data Jan Ekström
2023-03-24 10:49 ` Anton Khirnov
2023-03-24 17:35 ` Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 11/14] ffmpeg: pass first video AVFrame's side data to encoder Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 12/14] avcodec/libsvtav1: add support for writing out CLL and MDCV Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 13/14] avcodec/libx264: " Jan Ekström
2023-03-20 23:34 ` [FFmpeg-devel] [PATCH v0 14/14] avcodec/libx265: " Jan Ekström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320233408.134255-5-jeebjp@gmail.com \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git